All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: cache-tauros2: remove ARMv6 code
Date: Thu, 27 Mar 2014 02:53:24 +0100	[thread overview]
Message-ID: <201403270253.24594.arnd@arndb.de> (raw)
In-Reply-To: <CAN1soZz6-+s4bKbCJFXQResa07Ub9s1qfRrf2nDLC8eFVQEDsg@mail.gmail.com>

On Tuesday 18 March 2014, Haojian Zhuang wrote:
> On Wed, Mar 12, 2014 at 2:51 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > When building a kernel with support for both ARMv6 and ARMv7 but
> > no MMU, the call from tauros2_internal_init to adjust_cr causes
> > a link error. While that could probably be resolved, we don't
> > actually support cache-tauros2 on ARMv6 any more. All PJ4 CPU
> > implementations support both ARMv6 and ARMv7 and we already assume
> > that we are using them only in ARMv7 mode.
> >
> > Removing the ARMv6 code path reduces the code size and avoids
> > the linker error.
> > -
> >  #ifdef CONFIG_CPU_32v7
> >         /*
> >          * Check whether this CPU has support for the v7 hierarchical
> >
> 
> Acked-by: Haojian Zhuang <haojian.zhuang@gmail.com>

I've merged it into next/soc now, since that branch originally
introduced the bug, which now prevents 'allmodconfig' from building.

I had to another oneline change to the patch, see below. This has
no functional impact, but just avoids a few "unused function" warnings
when building with both v6 and v7 enabled. Previously some of the
functions were shared between v5 and v6 code, but the v6 version
is removed now.

	Arnd

diff --git a/arch/arm/mm/cache-tauros2.c b/arch/arm/mm/cache-tauros2.c
index 7964ef2..b273739 100644
--- a/arch/arm/mm/cache-tauros2.c
+++ b/arch/arm/mm/cache-tauros2.c
@@ -33,7 +33,7 @@
  * outer cache operations into the kernel image if the kernel has been
  * configured to support a pre-v7 CPU.
  */
-#if __LINUX_ARM_ARCH__ < 7
+#ifdef CONFIG_CPU_32v5
 /*
  * Low-level cache maintenance operations.
  */

      parent reply	other threads:[~2014-03-27  1:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 18:51 [PATCH] ARM: cache-tauros2: remove ARMv6 code Arnd Bergmann
2014-03-18  8:27 ` Haojian Zhuang
2014-03-18 15:01   ` Arnd Bergmann
2014-03-27  1:53   ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201403270253.24594.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.