From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 27 Mar 2014 08:40:25 +0100 (CET) Received: from localhost.localdomain ([127.0.0.1]:54439 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6822083AbaC0HkWzeDfP (ORCPT ); Thu, 27 Mar 2014 08:40:22 +0100 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.7/8.14.4) with ESMTP id s2R7eJxp023062; Thu, 27 Mar 2014 08:40:19 +0100 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.7/8.14.7/Submit) id s2R7eGrA023061; Thu, 27 Mar 2014 08:40:16 +0100 Date: Thu, 27 Mar 2014 08:40:16 +0100 From: Ralf Baechle To: Aaro Koskinen Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, David Daney , stable@vger.kernel.org Subject: Re: [PATCH] MIPS: OCTEON: fix EARLY_PRINTK_8250 build failure Message-ID: <20140327074016.GN17197@linux-mips.org> References: <1395777525-28910-1-git-send-email-aaro.koskinen@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395777525-28910-1-git-send-email-aaro.koskinen@iki.fi> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 39589 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Tue, Mar 25, 2014 at 09:58:45PM +0200, Aaro Koskinen wrote: > Enabling EARLY_PRINTK_8250 breaks OCTEON builds because of multiple > prom_putchar() implementations. OCTEON provides its own prom_putchar() > (also used by the watchdog driver), so we should prevent user from > selecting EARLY_PRINTK_8250 on OCTEON. There shouldn't be Octeon-specific code in the 8250-driver, not even the Kconfig bits. Also other systems - at least Sibyte - affected by the same issue so I went for a different patch. Ralf