Re: [Qemu-devel] [PATCH 4/7] monitor: Add cpu index argument completion.

[Luiz Capitulino <lcapitulino@redhat.com>]

On Sun,  9 Mar 2014 12:16:14 +0100
Hani Benhabiles <kroosec@gmail.com> wrote:

> Signed-off-by: Hani Benhabiles <hani@linux.com>

Honest question: is this one really worth it? Aren't we just
auto-completing a single integer?

> ---
>  hmp-commands.hx |  1 +
>  hmp.h           |  1 +
>  monitor.c       | 24 ++++++++++++++++++++++++
>  3 files changed, 26 insertions(+)
> 
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index a411d4f..813c0fb 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -690,6 +690,7 @@ ETEXI
>          .params     = "index",
>          .help       = "set the default CPU",
>          .mhandler.cmd = hmp_cpu,
> +        .command_completion = cpu_completion,
>      },
>  
>  STEXI
> diff --git a/hmp.h b/hmp.h
> index dc03984..59a60ed 100644
> --- a/hmp.h
> +++ b/hmp.h
> @@ -98,6 +98,7 @@ void object_add_completion(Monitor *mon, int nb_args, const char *str);
>  void object_del_completion(Monitor *mon, int nb_args, const char *str);
>  void chardev_add_completion(Monitor *mon, int nb_args, const char *str);
>  void chardev_remove_completion(Monitor *mon, int nb_args, const char *str);
> +void cpu_completion(Monitor *mon, int nb_args, const char *str);
>  
>  
>  #endif
> diff --git a/monitor.c b/monitor.c
> index 73442c6..43aab76 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -4429,6 +4429,30 @@ void object_del_completion(Monitor *mon, int nb_args, const char *str)
>      qapi_free_ObjectPropertyInfoList(start);
>  }
>  
> +void cpu_completion(Monitor *mon, int nb_args, const char *str)
> +{
> +    CpuInfoList *cpu_list, *start;
> +    size_t len;
> +
> +    if (nb_args != 2) {
> +        return;
> +    }
> +    len = strlen(str);
> +    readline_set_completion_index(mon->rs, len);
> +
> +    start = cpu_list = qmp_query_cpus(NULL);
> +    while (cpu_list) {
> +        char name[16];
> +        snprintf(name, sizeof(name), "%" PRId64, cpu_list->value->CPU);
> +
> +        if (!strncmp(str, name, len)) {
> +            readline_add_completion(mon->rs, name);
> +        }
> +        cpu_list = cpu_list->next;
> +    }
> +    qapi_free_CpuInfoList(start);
> +}
> +
>  static void monitor_find_completion_by_table(Monitor *mon,
>                                               const mon_cmd_t *cmd_table,
>                                               char **args,