All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Kay Sievers <kay@vrfy.org>
Cc: Tom Gundersen <teg@jklm.no>, virtualization@lists.linux-foundation.org
Subject: Re: udev PATH_ID for virtio devices
Date: Thu, 27 Mar 2014 21:13:55 +0200	[thread overview]
Message-ID: <20140327191355.GB4114@redhat.com> (raw)
In-Reply-To: <CAPXgP10kov-O2ecWBhyBA3rRj_t7FHYy2jn8LyjVvMu-ozxWAQ@mail.gmail.com>

On Thu, Mar 27, 2014 at 08:06:15PM +0100, Kay Sievers wrote:
> On Thu, Mar 27, 2014 at 7:59 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Thu, Mar 27, 2014 at 07:43:34PM +0100, Kay Sievers wrote:
> >> On Thu, Mar 27, 2014 at 6:30 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> >>
> >> > If the virtio device is a PCI device, it is really best to
> >> > treat it like you treat any other PCI function (I guess you mean
> >> > function and not device, right? We support multifunction
> >> > devices and some people do pack multiple NICs in a single device)..
> >> >
> >> > At the moment many devices in a single pci function can not happen on a
> >> > PCI system (no multiport) but if we add multiport, we'll follow some
> >> > existing standard to expose this information to the guest.
> >>
> >> This means, that there can currently never multiple devices below one
> >> and the same virtio parent device?
> 
> > There's a single virtio device per pci function (you keep saying
> > device but I hope the distinction is clear and this is
> > just slip of the tongue).
> 
> Right, we talks about sysfs directories and they are called "device",
> we don't really care about the actual bus that is implemented,
> userspace does not really know much about them. :)
> 
> > For net devices under a pci function that is also currently the case,
> > but I can't yet tell you for sure ahead of the time how we'll present
> > multiport devices if we ever implement them.
> >
> > I'm guessing there will be multiple net devices under
> > a single pci device and we'll present a sysfs attribute with the port
> > number in this case.
> >
> > Hmm maybe we should go ahead and add a place-holder
> > attribute so that it's future-proof?
> >
> > I'll write a patch like that and we'll see how it's accepted.
> 
> Netdevs with multiple ports are represented with the standard "dev_id"
> attribute identifying the instance of the driver per parent "device";
> should all work already from the userspace side, if the virtio side
> would use that too.
> 
> Kay

Aha. In that case it's easy - pls assume that if and when we implement
multiple we'll just follow standards and use dev_id.
For virtio pci devices specifically virtio<->pci 1:1 mapping is set
in stone in the spec.

Non pci ones need to be examined separately.

  reply	other threads:[~2014-03-27 19:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAG-2HqURZE_KtaxOx=9YH+9W0Ar56SLvcvLB6Be6QS3mvVTdWA@mail.gmail.com>
     [not found] ` <20140327173009.GA2593@redhat.com>
     [not found]   ` <CAPXgP12KbrUhpQyXxXnEo80-xyDz4089Y9uwtd7b5OGH9tSguQ@mail.gmail.com>
2014-03-27 18:59     ` udev PATH_ID for virtio devices Michael S. Tsirkin
2014-03-27 19:06       ` Kay Sievers
2014-03-27 19:13         ` Michael S. Tsirkin [this message]
2014-03-27 19:25           ` Kay Sievers
2014-03-27 20:24             ` Tom Gundersen
2014-03-27 20:58               ` Michael S. Tsirkin
2015-08-24 16:10                 ` Tom Gundersen
2015-08-25 11:43                   ` Michael S. Tsirkin
2015-08-25 11:46                     ` Kay Sievers
2015-08-25 11:52                       ` Michael S. Tsirkin
2015-08-25 11:58                         ` Kay Sievers
2015-09-02 11:53                           ` Tom Gundersen
2015-09-02 12:09                             ` Michael S. Tsirkin
2015-09-02 12:14                               ` Tom Gundersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140327191355.GB4114@redhat.com \
    --to=mst@redhat.com \
    --cc=kay@vrfy.org \
    --cc=teg@jklm.no \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.