Re: dib0700 NEC scancode question

["David Härdeman" <david@hardeman.nu>]

On Thu, Mar 27, 2014 at 01:07:28PM +0100, David Härdeman wrote:
>Hi Patrick,
>
>a quick question regarding the dib0700 driver:
>
>in ./media/usb/dvb-usb/dib0700_core.c the RC RX packet is defined as:
...
>The NEC protocol transmits in the order:
...
>Does the dib0700 fw really reorder the bytes, or could the order of
>not_system and system in struct dib0700_rc_response have been
>accidentally reversed?
...
>Which, if the order *is* reversed, would mean that the scancode that
>gets defined is in reality:
>
>	keycode = poll_reply->system     << 16 |
>		  poll_reply->not_system << 8  |
>		  poll_reply->data;
>
>Which is the same as the order used in drivers/media/rc/ir-nec-decoder.c.
>
>(An order which I'm considering trying to correct, which is why I'm
s/correct/make sure it's consistent/

-- 
David Härdeman