From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTI90-0007ji-Pc for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:47:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTI8r-0007rN-Vw for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:47:26 -0400 Received: from mail-ee0-x22b.google.com ([2a00:1450:4013:c00::22b]:43125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTI8r-0007qk-P5 for qemu-devel@nongnu.org; Thu, 27 Mar 2014 17:47:17 -0400 Received: by mail-ee0-f43.google.com with SMTP id e53so3384601eek.16 for ; Thu, 27 Mar 2014 14:47:16 -0700 (PDT) Date: Thu, 27 Mar 2014 22:47:11 +0100 From: Hani Benhabiles Message-ID: <20140327214711.GB22714@Inspiron-3521> References: <1394363777-14132-1-git-send-email-kroosec@gmail.com> <20140327162615.04aa25d4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140327162615.04aa25d4@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/7] monitor: Completion support for various commands. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, qemu-devel@nongnu.org, Markus Armbruster , stefanha@redhat.com, imammedo@redhat.com On Thu, Mar 27, 2014 at 04:26:15PM -0400, Luiz Capitulino wrote: > On Sun, 9 Mar 2014 12:16:10 +0100 > Hani Benhabiles wrote: > > > This patch series adds a new callback to mon_cmd_t which will make adding > > completion support for more commands cleaner. > > > > It then adds full or partial arguments completion for 7 different hmp commands. > > The general approach seems OK to me, but I could use some help to review > the entire series. > > Stefan, could you please review the set_link(), netdev_add/del() changes? > Better review the new series I will send soon.