All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v7 00/17] locks: fixes for 3.15 and file-private lock support
Date: Thu, 27 Mar 2014 22:15:33 -0400	[thread overview]
Message-ID: <20140328021533.GG27633@fieldses.org> (raw)
In-Reply-To: <1395261961-10855-1-git-send-email-jlayton@redhat.com>

On Wed, Mar 19, 2014 at 04:45:44PM -0400, Jeff Layton wrote:
> This is a re-posting of patches that I have queued for 3.15. There's
> really nothing new in this pile vs. the last several sets that I've
> posted. This is mainly just a re-posting of them all as one complete
> set. The only real difference is a fix for one of the mandatory locking
> patches when CONFIG_FILE_LOCKING is disabled (many thanks to AKPM for
> pointing that out).
> 
> Most of this pile has been sitting in linux-next since 3.14-rc1, and
> I've heard zero complaints aside from a minor merge conflict with one of
> Heiko Carstens's patches. A few patches were added later and haven't
> been soaking in linux-next for as long, but they've been there for a
> little while now.

For what it's worth, I also ran this through my regression tests (cthon,
pynfs, plus a few other small lock tests, locally and over v3 and v4),
and didn't see any problems.  Of course that doesn't exercise the new
lock type.

--b.

> 
> Al would you be willing to take these into your tree and merge them up
> to Linus for 3.15 (assuming no one objects, of cours)? It may be easier
> to cherry pick them from my linux-next branch:
> 
>     git://git.samba.org/jlayton/linux.git linux-next
> 
> Thanks! Comments and suggestions welcome...
> 
> J. Bruce Fields (1):
>   locks: fix posix lock range overflow handling
> 
> Jeff Layton (16):
>   locks: close potential race between setlease and open
>   locks: clean up comment typo
>   locks: remove "inline" qualifier from fl_link manipulation functions
>   locks: add __acquires and __releases annotations to locks_start and
>     locks_stop
>   locks: eliminate BUG() call when there's an unexpected lock on file
>     close
>   locks: consolidate checks for compatible filp->f_mode values in setlk
>     handlers
>   locks: rename locks_remove_flock to locks_remove_file
>   MAINTAINERS: add Bruce and myself to list of maintainers for file
>     locking code
>   locks: make /proc/locks show IS_FILE_PVT locks with a P suffix
>   locks: report l_pid as -1 for FL_FILE_PVT locks
>   locks: pass the cmd value to fcntl_getlk/getlk64
>   locks: skip deadlock detection on FL_FILE_PVT locks
>   locks: add new fcntl cmd values for handling file private locks
>   locks: require that flock->l_pid be set to 0 for file-private locks
>   locks: fix locks_mandatory_locked to respect file-private locks
>   locks: make locks_mandatory_area check for file-private locks
> 
>  MAINTAINERS                       |   2 +
>  arch/arm/kernel/sys_oabi-compat.c |   3 +
>  fs/compat.c                       |  35 +++-
>  fs/fcntl.c                        |  37 ++--
>  fs/file_table.c                   |   2 +-
>  fs/locks.c                        | 387 ++++++++++++++++++++++++--------------
>  fs/namei.c                        |   2 +-
>  include/linux/fs.h                |  43 +++--
>  include/uapi/asm-generic/fcntl.h  |  19 +-
>  mm/mmap.c                         |   2 +-
>  mm/nommu.c                        |   2 +-
>  security/selinux/hooks.c          |   3 +
>  12 files changed, 354 insertions(+), 183 deletions(-)
> 
> -- 
> 1.8.5.3
> 

      parent reply	other threads:[~2014-03-28  2:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 20:45 [PATCH v7 00/17] locks: fixes for 3.15 and file-private lock support Jeff Layton
2014-03-19 20:45 ` [PATCH v7 01/17] locks: close potential race between setlease and open Jeff Layton
2014-03-19 20:45 ` [PATCH v7 02/17] locks: clean up comment typo Jeff Layton
2014-03-23 19:54   ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 03/17] locks: remove "inline" qualifier from fl_link manipulation functions Jeff Layton
2014-03-23 19:55   ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 04/17] locks: add __acquires and __releases annotations to locks_start and locks_stop Jeff Layton
2014-03-23 19:55   ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 05/17] locks: eliminate BUG() call when there's an unexpected lock on file close Jeff Layton
2014-03-23 20:01   ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 06/17] locks: fix posix lock range overflow handling Jeff Layton
2014-03-19 20:45 ` [PATCH v7 07/17] locks: consolidate checks for compatible filp->f_mode values in setlk handlers Jeff Layton
2014-03-23 20:08   ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 08/17] locks: rename locks_remove_flock to locks_remove_file Jeff Layton
2014-03-23 22:58   ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 09/17] MAINTAINERS: add Bruce and myself to list of maintainers for file locking code Jeff Layton
2014-03-19 20:45 ` [PATCH v7 10/17] locks: make /proc/locks show IS_FILE_PVT locks with a P suffix Jeff Layton
2014-03-25  0:20   ` J. Bruce Fields
2014-03-25  0:57     ` Jeffrey Layton
2014-03-25  4:18       ` J. Bruce Fields
2014-03-29 14:18         ` Jeff Layton
2014-03-29 19:05           ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 11/17] locks: report l_pid as -1 for FL_FILE_PVT locks Jeff Layton
2014-03-25  0:30   ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 12/17] locks: pass the cmd value to fcntl_getlk/getlk64 Jeff Layton
2014-03-19 20:45 ` [PATCH v7 13/17] locks: skip deadlock detection on FL_FILE_PVT locks Jeff Layton
2014-03-28 21:43   ` J. Bruce Fields
2014-03-19 20:45 ` [PATCH v7 14/17] locks: add new fcntl cmd values for handling file private locks Jeff Layton
2014-03-19 20:45 ` [PATCH v7 15/17] locks: require that flock->l_pid be set to 0 for file-private locks Jeff Layton
2014-03-19 20:46 ` [PATCH v7 16/17] locks: fix locks_mandatory_locked to respect " Jeff Layton
2014-03-19 20:46 ` [PATCH v7 17/17] locks: make locks_mandatory_area check for " Jeff Layton
2014-03-28  2:15 ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140328021533.GG27633@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.