From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] systemd: disable build for unsupported architectures.
Date: Fri, 28 Mar 2014 12:11:56 +0100 [thread overview]
Message-ID: <20140328121156.6d49c688@skate> (raw)
In-Reply-To: <1396001767-4910-1-git-send-email-eric.le.bihan.dev@free.fr>
Dear Eric Le Bihan,
On Fri, 28 Mar 2014 11:16:07 +0100, Eric Le Bihan wrote:
> Systemd only supports the architectures defined in
> src/shared/architecture.h. This list does not contain ARC, Blackfin,
> Xtensa, Microblaze and Nios2, so this package is disabled for these
> architectures.
>
> Fixes
> http://autobuild.buildroot.net/results/bcc/bcce95eb0748505c0d62db21a6e420aae3c3181b/
>
> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> ---
> package/systemd/Config.in | 2 ++
> system/Config.in | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/package/systemd/Config.in b/package/systemd/Config.in
> index 838e13e..66b5fc4 100644
> --- a/package/systemd/Config.in
> +++ b/package/systemd/Config.in
> @@ -2,6 +2,8 @@ config BR2_PACKAGE_SYSTEMD
> bool "systemd"
> depends on BR2_INIT_SYSTEMD
> depends on !BR2_avr32 # no epoll_create1
> + depends on !BR2_arc && !BR2_bfin && !BR2_xtensa
> + depends on !BR2_microblaze && !BR2_nios2
Maybe it's better to use positive logic here, and only explicitly allow
systemd on the architectures that it supports. This way if tomorrow we
add support for a new architecture, we won't get weird failures.
In package/systemd/Config.in:
config BR2_PACKAGE_SYSTEMD_ARCH_SUPPORTS
bool
default y if BR2_arm || BR2_powerpc || BR2_...
and then use "depends on BR2_PACKAGE_SYSTEM_ARCH_SUPPORTS" where needed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-28 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 10:16 [Buildroot] [PATCH 1/1] systemd: disable build for unsupported architectures Eric Le Bihan
2014-03-28 11:11 ` Thomas Petazzoni [this message]
2014-03-28 16:24 ` Eric Le Bihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328121156.6d49c688@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.