From: Patrick McHardy <kaber@trash.net>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [nf_tables RFH PATCH] netfilter: nf_tables: add set_elem notifications
Date: Fri, 28 Mar 2014 12:15:27 +0000 [thread overview]
Message-ID: <20140328121527.GA7610@macbook.localnet> (raw)
In-Reply-To: <20140328114622.8896.14752.stgit@nfdev.cica.es>
On Fri, Mar 28, 2014 at 12:46:22PM +0100, Arturo Borrero Gonzalez wrote:
> +static int nf_tables_setelem_notify(const struct nft_ctx *ctx,
> + const struct nft_set *set,
> + const struct nft_set_elem *elem,
> + int event, u16 flags)
> +{
> ...
> + err = nfnetlink_send(skb, net, portid, NFNLGRP_NFTABLES, report,
> + GFP_KERNEL);
> +err_free:
> + kfree_skb(skb);
There's the reason of your crash. You must not free the skb after sending it.
next prev parent reply other threads:[~2014-03-28 12:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 11:46 [nf_tables RFH PATCH] netfilter: nf_tables: add set_elem notifications Arturo Borrero Gonzalez
2014-03-28 11:49 ` Pablo Neira Ayuso
2014-03-28 12:00 ` Arturo Borrero Gonzalez
2014-03-28 12:02 ` Patrick McHardy
2014-03-28 11:55 ` Patrick McHardy
2014-03-28 12:15 ` Patrick McHardy [this message]
2014-03-28 12:28 ` Pablo Neira Ayuso
2014-03-28 13:24 ` Arturo Borrero Gonzalez
-- strict thread matches above, loose matches on Subject: below --
2014-03-19 16:05 Arturo Borrero Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328121527.GA7610@macbook.localnet \
--to=kaber@trash.net \
--cc=arturo.borrero.glez@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.