From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 4/7] netfilter: nf_tables: better encapsulation for the rule transaction code
Date: Fri, 28 Mar 2014 12:53:09 +0000 [thread overview]
Message-ID: <20140328125308.GD7895@macbook.localnet> (raw)
In-Reply-To: <1395957197-4899-5-git-send-email-pablo@netfilter.org>
On Thu, Mar 27, 2014 at 10:53:14PM +0100, Pablo Neira Ayuso wrote:
> Another cleanup to accomodate set, chain and table transaction support.
> Move the rule transaction code to several functions to avoid too large
> commit and abort routines.
>
> +static void nft_rule_commit_update(struct net *net, struct sk_buff *skb,
> + struct nft_trans *trans)
Just wondering, why aren't we using the net and skb from the context?
> +static void nft_rule_abort_undo(struct net *net, struct sk_buff *skb,
> + struct nft_trans *trans)
In this case neither net nor skb are used.
next prev parent reply other threads:[~2014-03-28 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 21:53 [PATCH 0/7] new transaction infrastructure for nf_tables Pablo Neira Ayuso
2014-03-27 21:53 ` [PATCH 1/7] netfilter: nf_tables: deconstify table and chain in context structure Pablo Neira Ayuso
2014-03-28 12:42 ` Patrick McHardy
2014-03-28 12:57 ` Pablo Neira Ayuso
2014-03-27 21:53 ` [PATCH 2/7] netfilter: nf_tables: generalise transaction infrastructure Pablo Neira Ayuso
2014-03-28 12:42 ` Patrick McHardy
2014-03-27 21:53 ` [PATCH 3/7] netfilter: nf_tables: relocate commit and abort routines in the source file Pablo Neira Ayuso
2014-03-27 21:53 ` [PATCH 4/7] netfilter: nf_tables: better encapsulation for the rule transaction code Pablo Neira Ayuso
2014-03-28 12:53 ` Patrick McHardy [this message]
2014-03-27 21:53 ` [PATCH 5/7] netfilter: nf_tables: move set handling to the transaction infrastructure Pablo Neira Ayuso
2014-03-28 13:00 ` Patrick McHardy
2014-03-27 21:53 ` [PATCH 6/7] netfilter: nf_tables: move chain " Pablo Neira Ayuso
2014-03-28 13:10 ` Patrick McHardy
2014-03-27 21:53 ` [PATCH 7/7] netfilter: nf_tables: move table " Pablo Neira Ayuso
2014-03-28 13:12 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328125308.GD7895@macbook.localnet \
--to=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.