From: "David Härdeman" <david@hardeman.nu>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-media@vger.kernel.org, m.chehab@samsung.com
Subject: Re: [PATCH] rc-core: do not change 32bit NEC scancode format for now
Date: Sat, 29 Mar 2014 17:14:28 +0100 [thread overview]
Message-ID: <20140329161428.GA13387@hardeman.nu> (raw)
In-Reply-To: <22162617.bKffkdqYH7@radagast>
On Fri, Mar 28, 2014 at 11:17:09PM +0000, James Hogan wrote:
>On Friday 28 March 2014 01:08:56 David Härdeman wrote:
>> drivers/media/usb/dvb-usb-v2/az6007.c
>> drivers/media/usb/dvb-usb-v2/af9035.c
>> drivers/media/usb/dvb-usb-v2/rtl28xxu.c
>> drivers/media/usb/dvb-usb-v2/af9015.c
>> drivers/media/usb/em28xx/em28xx-input.c
>
>Note, it appears none of these do any bit reversing for the 32bit case
>compared to 16/24 bit, so they're already different to the NEC32 scancode
>encoding that the raw nec decoder and tivo keymap were using, which used a
>different bitorder (!!) between the 32-bit and the 24/16-bit cases.
I know, and none of those drivers have an in-kernel NEC32 keymap, so if
anyone is using them in that manner...it's with a homebrew keymap.
>> I'd rather show you my complete proposal first before doing something
>> radical with your driver. But it was a good reminder that I need to keep
>> the NEC32 parsing in your driver in mind as well.
>
>Okay no problem. I had assumed you were aiming for a short term fix to prevent
>the encoding change hitting mainline or an actual release (v3.15).
I am aiming for a fix within that time frame...but I hope that it can be
more than a short term one :)
Patches are on their way right now...
Regards,
David
next prev parent reply other threads:[~2014-03-29 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 21:00 [PATCH] rc-core: do not change 32bit NEC scancode format for now David Härdeman
2014-03-27 23:21 ` James Hogan
2014-03-28 0:08 ` David Härdeman
2014-03-28 23:17 ` James Hogan
2014-03-29 16:14 ` David Härdeman [this message]
2014-03-31 19:43 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140329161428.GA13387@hardeman.nu \
--to=david@hardeman.nu \
--cc=james.hogan@imgtec.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.