All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] Makefile.in: add -mtext-section-literals to xtensa ABI
Date: Sun, 30 Mar 2014 19:36:46 +0300	[thread overview]
Message-ID: <20140330163646.GO4579@tarshish> (raw)
In-Reply-To: <1396196521-30184-3-git-send-email-jcmvbkbc@gmail.com>

Hi Max,

On Sun, Mar 30, 2014 at 08:22:01PM +0400, Max Filippov wrote:
> Collecting literals into separate section can be advantageous if that
> section is placed into DTCM at link time. This is applicable for code
> running on bare metal, but makes no sense under linux, where userspace
> is isolated from the physical memory details. OTOH placing literals into
> separate section breaks build of huge source files, because l32r
> instruction can only access literals in 256 KBytes range.
> 
> Add -mtext-section-literals into xtensa ABI to fix build issues of
> packages with huge sources.
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  package/Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/Makefile.in b/package/Makefile.in
> index eea7043..31c72a0 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -73,7 +73,7 @@ endif
>  # code size and performance, the linker can usually optimize away the
>  # overhead when a call ends up within a certain range.

Please add the commit log explanation to the comment here.

>  ifeq ($(BR2_xtensa),y)
> -TARGET_ABI += -mlongcalls
> +TARGET_ABI += -mlongcalls -mtext-section-literals

With this in place a follow-up patch should remove local 
-mtext-section-literals that I sprinkled on various packages to fix xtensa 
build failures.

Thanks,
baruch

>  endif
>  
>  STAGING_SUBDIR = usr/$(GNU_TARGET_NAME)/sysroot

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2014-03-30 16:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-30 16:21 [Buildroot] [PATCH 0/2] xtensa: add -mtext-section-literals to xtensa ABI Max Filippov
2014-03-30 16:22 ` [Buildroot] [PATCH 1/2] uclibc: add missing .literal_position directives Max Filippov
2014-03-30 16:22 ` [Buildroot] [PATCH 2/2] Makefile.in: add -mtext-section-literals to xtensa ABI Max Filippov
2014-03-30 16:36   ` Baruch Siach [this message]
2014-03-30 16:40     ` Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140330163646.GO4579@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.