All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Alexei Starovoitov <ast@plumgrid.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Daniel Borkmann <dborkman@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: ptp: oki-semi: fix build dependency
Date: Mon, 31 Mar 2014 11:21:54 +0200	[thread overview]
Message-ID: <20140331092153.GC6867@netboy> (raw)
In-Reply-To: <1396247539-27298-1-git-send-email-ast@plumgrid.com>

On Sun, Mar 30, 2014 at 11:32:19PM -0700, Alexei Starovoitov wrote:

> -	depends on PCI && (X86 || COMPILE_TEST)
> +	depends on PCI && NETWORK_PHY_TIMESTAMPING && (X86 || COMPILE_TEST)

This is not the way to fix it.

Enabling NETWORK_PHY_TIMESTAMPING puts extra checks into the hot path
for every skb passed to netif_receive_skb(). It only makes sense to
pay this extra cost if you actually have a time stamping PHY.

So instead, move the classifier routine out of timestamping.c to a
place where it is always compiled into the stack.

Thanks,
Richard

      reply	other threads:[~2014-03-31  9:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31  6:32 [PATCH net-next] net: ptp: oki-semi: fix build dependency Alexei Starovoitov
2014-03-31  9:21 ` Richard Cochran [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140331092153.GC6867@netboy \
    --to=richardcochran@gmail.com \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.