From: Borislav Petkov <bp@alien8.de>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
Borislav Petkov <bp@suse.de>, Jacob Shin <jacob.shin@amd.com>,
Jeff Layton <jlayton@redhat.com>,
Prarit Bhargava <prarit@redhat.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86: microcode: report if no microcode file was found
Date: Mon, 31 Mar 2014 18:26:33 +0200 [thread overview]
Message-ID: <20140331162633.GC16144@pd.tnic> (raw)
In-Reply-To: <1396188574-2067-2-git-send-email-dvlasenk@redhat.com>
On Sun, Mar 30, 2014 at 04:09:33PM +0200, Denys Vlasenko wrote:
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index ef8b17c..9ce22b0 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -279,7 +279,7 @@ static enum ucode_state request_microcode_fw(int cpu, struct device *device,
> c->x86, c->x86_model, c->x86_mask);
>
> if (request_firmware_direct(&firmware, name, device)) {
request_firmware_direct() already has dev_dbg() error messages down its
path.
> - pr_debug("data file %s load failed\n", name);
> + pr_info("data file %s load failed\n", name);
Also might spook users unnecessarily.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-03-31 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-30 14:09 [PATCH 1/3] x86: microcode: report if CPU has up-to-date microcode Denys Vlasenko
2014-03-30 14:09 ` [PATCH 2/3] x86: microcode: report if no microcode file was found Denys Vlasenko
2014-03-31 16:26 ` Borislav Petkov [this message]
2014-03-30 14:09 ` [PATCH 3/3] x86: microcode: remove unused parameter and redundant variable Denys Vlasenko
2014-03-31 16:23 ` [PATCH 1/3] x86: microcode: report if CPU has up-to-date microcode Borislav Petkov
2014-03-31 17:08 ` Denys Vlasenko
2014-04-13 16:09 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331162633.GC16144@pd.tnic \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=dvlasenk@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@linux.intel.com \
--cc=jacob.shin@amd.com \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.