From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: Make drm_clflush_virt_range() void* Date: Mon, 31 Mar 2014 19:28:26 +0300 Message-ID: <20140331162826.GW21652@intel.com> References: <1396278531-27778-1-git-send-email-ville.syrjala@linux.intel.com> <20140331154047.GB7314@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 8B01C6E37A for ; Mon, 31 Mar 2014 09:28:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140331154047.GB7314@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, Mar 31, 2014 at 04:40:47PM +0100, Chris Wilson wrote: > On Mon, Mar 31, 2014 at 06:08:51PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > Currently drm_cflush_virt_rage() takes a char* so the caller probably > > has to do pointless casting to avoid compiler warnings. Make the > > argument void* instead to avoid such issues. > > = > > Signed-off-by: Ville Syrj=E4l=E4 > = > Can we not use a gcc'ism to allow pointer arithmetic on void *? Personally I'd be fine with that. So if no one disagrees I can send a v2. -- = Ville Syrj=E4l=E4 Intel OTC