From: Lauri Kasanen <cand@gmx.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/ttm: Add optional support for two-ended allocation
Date: Mon, 31 Mar 2014 17:51:46 +0300 [thread overview]
Message-ID: <20140331175146.49a38884.cand@gmx.com> (raw)
In-Reply-To: <1396269665.6681.4.camel@weser.hi.pengutronix.de>
On Mon, 31 Mar 2014 14:41:05 +0200
Lucas Stach <l.stach@pengutronix.de> wrote:
> Am Montag, den 31.03.2014, 15:28 +0300 schrieb Lauri Kasanen:
> > Allocating small bos from one end and large ones from the other helps
> > improve the quality of fragmentation.
> >
> > This depends on "drm: Optionally create mm blocks from top-to-bottom" by
> > Chris Wilson.
> >
> You are breaking bisectability here. This patch deliberately introduces
> a build failure that you only fix up in the next two patches. This isn't
> acceptable, you must squash the following patches in to avoid the
> breakage.
>
> Also if the first patch is from Chris Wilson and you only did some small
> changes this should be reflected in the author name of the patch.
OK, will squash and resend. Then the changes are mostly mine in the
singular patch.
BTW, how would I handle the case of a different author, when I cannot
use git-send-email due to network mail restrictions? I can't send email
from an address I don't own.
- Lauri
next prev parent reply other threads:[~2014-03-31 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 12:28 [PATCH 2/4] drm/ttm: Add optional support for two-ended allocation Lauri Kasanen
2014-03-31 12:41 ` Lucas Stach
2014-03-31 14:51 ` Lauri Kasanen [this message]
2014-03-31 15:08 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331175146.49a38884.cand@gmx.com \
--to=cand@gmx.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=l.stach@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.