All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] clk: shmobile: rcar-gen2: fix lb/sd0/sd1/sdh clock parent to pll1
Date: Mon, 31 Mar 2014 18:13:10 +0000	[thread overview]
Message-ID: <20140331181310.5762.78686@quantum> (raw)
In-Reply-To: <1396277434-24925-1-git-send-email-ben.dooks@codethink.co.uk>

Quoting Ben Dooks (2014-03-31 07:50:34)
> The clock generator for rcar-gen2 has the lb, sdh, sd0 and sd1 clocks
> parented to pll1_div2 where the hardware diagram shows these to be
> directly fed from pll1.
> 
> This fixes the initial rate for sdh0 clock to be 97.5MHz instead of
> the reported 48MHz where the manual says the default register values
> are for 97.5MHz.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Taken into clk-next.

Regards,
Mike

> ---
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Cc: Mike Turquette <mturquette@linaro.org>
> Cc: linux-sh@vger.kernel.org
> Cc: Simon Horman <horms+renesas@verge.net.au>
> ---
>  drivers/clk/shmobile/clk-rcar-gen2.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/shmobile/clk-rcar-gen2.c b/drivers/clk/shmobile/clk-rcar-gen2.c
> index 01cb49c..7c6be44 100644
> --- a/drivers/clk/shmobile/clk-rcar-gen2.c
> +++ b/drivers/clk/shmobile/clk-rcar-gen2.c
> @@ -249,22 +249,22 @@ rcar_gen2_cpg_register_clock(struct device_node *np, struct rcar_gen2_cpg *cpg,
>                 parent_name = "main";
>                 mult = config->pll3_mult;
>         } else if (!strcmp(name, "lb")) {
> -               parent_name = "pll1_div2";
> +               parent_name = "pll1";
>                 div = cpg_mode & BIT(18) ? 36 : 24;
>         } else if (!strcmp(name, "qspi")) {
>                 parent_name = "pll1_div2";
>                 div = (cpg_mode & (BIT(3) | BIT(2) | BIT(1))) = BIT(2)
>                     ? 8 : 10;
>         } else if (!strcmp(name, "sdh")) {
> -               parent_name = "pll1_div2";
> +               parent_name = "pll1";
>                 table = cpg_sdh_div_table;
>                 shift = 8;
>         } else if (!strcmp(name, "sd0")) {
> -               parent_name = "pll1_div2";
> +               parent_name = "pll1";
>                 table = cpg_sd01_div_table;
>                 shift = 4;
>         } else if (!strcmp(name, "sd1")) {
> -               parent_name = "pll1_div2";
> +               parent_name = "pll1";
>                 table = cpg_sd01_div_table;
>                 shift = 0;
>         } else if (!strcmp(name, "z")) {
> -- 
> 1.9.0
> 

  reply	other threads:[~2014-03-31 18:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 14:50 [PATCH] clk: shmobile: rcar-gen2: fix lb/sd0/sd1/sdh clock parent to pll1 Ben Dooks
2014-03-31 18:13 ` Mike Turquette [this message]
2014-03-31 23:38 ` Laurent Pinchart
2014-04-01  0:00 ` Mike Turquette
2014-04-01  9:53 ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140331181310.5762.78686@quantum \
    --to=mturquette@linaro.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.