All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David Härdeman" <david@hardeman.nu>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-media@vger.kernel.org, m.chehab@samsung.com
Subject: Re: [PATCH 03/11] rc-core: document the protocol type
Date: Mon, 31 Mar 2014 21:39:29 +0200	[thread overview]
Message-ID: <20140331193929.GD9610@hardeman.nu> (raw)
In-Reply-To: <53393B73.3010405@imgtec.com>

On Mon, Mar 31, 2014 at 10:54:59AM +0100, James Hogan wrote:
>On 29/03/14 16:11, David Härdeman wrote:
>> Right now the protocol information is not preserved, rc-core gets handed a
>> scancode but has no idea which protocol it corresponds to.
>> 
>> This patch (which required reading through the source/keymap for all drivers,
>> not fun) makes the protocol information explicit which is important
>> documentation and makes it easier to e.g. support multiple protocols with one
>> decoder (think rc5 and rc-streamzap). The information isn't used yet so there
>> should be no functional changes.
>> 
>> Signed-off-by: David Härdeman <david@hardeman.nu>
>
>Good stuff. I very much approve of the concept, and had considered doing
>the same thing myself.

Thanks, and to reiterate, the patch misses two drivers so I'll still
repost a new version...

-- 
David Härdeman

  reply	other threads:[~2014-03-31 19:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-29 16:10 [PATCH 00/11] rc-core: My current patch queue David Härdeman
2014-03-29 16:10 ` [PATCH 01/11] bt8xx: fixup RC5 decoding David Härdeman
2014-03-29 16:10 ` [PATCH 02/11] rc-core: improve ir-kbd-i2c get_key functions David Härdeman
2014-03-29 16:11 ` [PATCH 03/11] rc-core: document the protocol type David Härdeman
2014-03-31  9:54   ` James Hogan
2014-03-31 19:39     ` David Härdeman [this message]
2014-03-29 16:11 ` [PATCH 04/11] rc-core: do not change 32bit NEC scancode format for now David Härdeman
2014-03-31  9:09   ` James Hogan
2014-03-29 16:11 ` [PATCH 05/11] rc-core: split dev->s_filter David Härdeman
2014-04-03 23:27   ` James Hogan
2014-03-29 16:11 ` [PATCH 06/11] rc-core: remove generic scancode filter David Härdeman
2014-03-31  9:29   ` James Hogan
2014-03-31 19:38     ` David Härdeman
2014-03-31 22:01       ` James Hogan
2014-03-29 16:11 ` [PATCH 07/11] dib0700: NEC scancode cleanup David Härdeman
2014-03-29 16:11 ` [PATCH 08/11] lmedm04: " David Härdeman
2014-03-29 16:11 ` [PATCH 09/11] saa7134: NEC scancode fix David Härdeman
2014-03-29 16:11 ` [PATCH 10/11] [RFC] rc-core: use the full 32 bits for NEC scancodes David Härdeman
2014-03-31  9:44   ` James Hogan
2014-03-31 10:19     ` David Härdeman
2014-03-31 10:56       ` James Hogan
2014-03-31 13:22         ` David Härdeman
2014-03-31 14:06           ` James Hogan
2014-03-31 15:26           ` Mauro Carvalho Chehab
2014-03-31 16:47             ` David Härdeman
2014-03-31 12:14       ` Mauro Carvalho Chehab
2014-03-31 12:58         ` David Härdeman
2014-03-31 13:15           ` Mauro Carvalho Chehab
2014-03-31 13:54             ` David Härdeman
2014-03-29 16:11 ` [PATCH 11/11] [RFC] rc-core: don't throw away protocol information David Härdeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140331193929.GD9610@hardeman.nu \
    --to=david@hardeman.nu \
    --cc=james.hogan@imgtec.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.