From: Dr Fields James Bruce <bfields@fieldses.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Idan Kedar <idank@primarydata.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] nfsd: Don't return NFS4ERR_RESTOREFH for NFSv4.1+
Date: Mon, 31 Mar 2014 16:52:44 -0400 [thread overview]
Message-ID: <20140331205244.GA20024@fieldses.org> (raw)
In-Reply-To: <54B21F4C-18EC-45B9-B89C-DD05A0922DDE@primarydata.com>
On Sat, Mar 29, 2014 at 04:01:15PM -0400, Trond Myklebust wrote:
>
> On Mar 29, 2014, at 15:49, Trond Myklebust <trond.myklebust@primarydata.com> wrote:
>
> >
> > On Mar 29, 2014, at 15:34, J. Bruce Fields <bfields@fieldses.org> wrote:
> >
> >> On Sat, Mar 29, 2014 at 02:43:39PM -0400, Trond Myklebust wrote:
> >>> RFC5661 obsoletes NFS4ERR_RESTOREFH in favour of NFS4ERR_NOFILEHANDLE.
> >>
> >> Looks right. Any objection to just making this nfserr_restorefh in the
> >> 4.0 case as well? Hard to imagine how that could cause a 4.0 client any
> >> problem.
> >
> > You mean make both cases return nfserr_nofilehandle (as per RFC5661), right? So, I agree that most clients should handle that, but the problem is that RFC3530bis does not allow it.
>
> Either way, this is not a performance critical issue. Any time we get into this situation, it is because the client is utterly screwed up in the first place.
Yeah. I don't really care much, applied.
> The NFS4ERR_STALE_STATEID is the critical one that really needs to be applied...
Already applied, thanks.
--b.
next prev parent reply other threads:[~2014-03-31 20:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-29 18:43 [PATCH 1/2] nfsd: Don't return NFS4ERR_STALE_STATEID for NFSv4.1+ Trond Myklebust
2014-03-29 18:43 ` [PATCH 2/2] nfsd: Don't return NFS4ERR_RESTOREFH " Trond Myklebust
2014-03-29 19:34 ` J. Bruce Fields
2014-03-29 19:49 ` Trond Myklebust
2014-03-29 20:01 ` Trond Myklebust
2014-03-31 20:52 ` Dr Fields James Bruce [this message]
2014-03-29 19:33 ` [PATCH 1/2] nfsd: Don't return NFS4ERR_STALE_STATEID " J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331205244.GA20024@fieldses.org \
--to=bfields@fieldses.org \
--cc=idank@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.