From: Greg KH <gregkh@linuxfoundation.org>
To: Denis Pithon <denis.pithon@gmail.com>
Cc: khoroshilov@ispras.ru, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging/wlan-ng fix small coding style issues
Date: Mon, 31 Mar 2014 14:34:31 -0700 [thread overview]
Message-ID: <20140331213431.GA31288@kroah.com> (raw)
In-Reply-To: <1396300452-1904-1-git-send-email-denis.pithon@gmail.com>
On Mon, Mar 31, 2014 at 11:14:12PM +0200, Denis Pithon wrote:
> * improve readability of usb_prism_tbl[]
> * remove obsolete comments for prism2sta_probe_usb() and
> prism2sta_disconnect_usb()
> * delete some unneeded blank lines and add few ones to make
> checkpatch.pl happy.
That's 3 different things, why not have 3 different patches here?
Remember, each patch should do only _one_ thing.
thanks,
greg k-h
next prev parent reply other threads:[~2014-03-31 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 21:14 [PATCH v2] staging/wlan-ng fix small coding style issues Denis Pithon
2014-03-31 21:34 ` Greg KH [this message]
2014-04-01 16:43 ` [PATCHv3 1/3] staging/wlan-ng: improve readability of usb_prism_tbl[] Denis Pithon
2014-04-01 16:43 ` [PATCHv3 2/3] staging/wlan-ng: remove obsolete comments Denis Pithon
2014-04-01 16:43 ` [PATCHv3 3/3] staging/wlan-ng: fix small coding style issues Denis Pithon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331213431.GA31288@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=denis.pithon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.