From: Greg KH <gregkh@linuxfoundation.org>
To: Anders Darander <anders.darander@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: ft1000-usb: fixed a few code style issues
Date: Mon, 31 Mar 2014 15:55:49 -0700 [thread overview]
Message-ID: <20140331225549.GA27227@kroah.com> (raw)
In-Reply-To: <1396247188-6513-1-git-send-email-anders.darander@gmail.com>
On Mon, Mar 31, 2014 at 08:26:28AM +0200, Anders Darander wrote:
> Fixed a few code style issues, particularly:
>
> Add do {} while (0) wrapper around seq_* macros.
> Change printk(KERN_WARN...) to netdev_warn(...).
That's 2 different things, please split this up into 2 different
patches.
Remember, one patch does one thing.
thanks,
greg k-h
next prev parent reply other threads:[~2014-03-31 22:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 6:26 [PATCH v2] Staging: ft1000-usb: fixed a few code style issues Anders Darander
2014-03-31 22:55 ` Greg KH [this message]
2014-04-01 6:34 ` Anders Darander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331225549.GA27227@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anders.darander@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.