From: Mike Snitzer <snitzer@redhat.com>
To: Akira Hayakawa <hayakawa@valinux.co.jp>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH 9/9] dm crypt: sort writes
Date: Mon, 31 Mar 2014 21:01:29 -0400 [thread overview]
Message-ID: <20140401010129.GB9214@redhat.com> (raw)
In-Reply-To: <20140401083755.55afa738d5a98b6bc07aca71@valinux.co.jp>
On Mon, Mar 31 2014 at 7:37pm -0400,
Akira Hayakawa <hayakawa@valinux.co.jp> wrote:
> Hi,
>
> This is just a comment.
>
> I like this sorting and I would like to apply this sorting code also to dm-writeboost.
> https://github.com/akiradeveloper/dm-writeboost
>
> Hope that improves the writeback.
> dm-writeboost writes back multiple (e.g. 4KB * 1000) data in cache device at once
> hoping that the scheduler sorts them implicitly.
> Explictly sort them possibly makes writeback more efficient.
>
> Thanks for the code.
OK. FYI, I cleaned the code up a little today based on Milan's dislike
for the #define within the function, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=039e943277604c3f4f6b4ee803b8793627d53d36
next prev parent reply other threads:[~2014-04-01 1:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 20:11 [PATCH 0/9] dm crypt: improve cpu scalability Mike Snitzer
2014-03-28 20:11 ` [PATCH 1/9] dm crypt: fix cpu hotplug crash by removing per-cpu structure Mike Snitzer
2014-03-28 20:11 ` [PATCH 2/9] block: use kmalloc alignment for bio slab Mike Snitzer
2014-03-28 20:11 ` [PATCH 3/9] dm crypt: use per-bio data Mike Snitzer
2014-03-28 20:11 ` [PATCH 4/9] dm crypt: use unbound workqueue for request processing Mike Snitzer
2014-03-28 20:11 ` [PATCH 5/9] dm crypt: don't allocate pages for a partial request Mike Snitzer
2014-03-28 20:11 ` [PATCH 6/9] dm crypt: avoid deadlock in mempools Mike Snitzer
2014-03-28 20:11 ` [PATCH 7/9] dm crypt: remove io_pool Mike Snitzer
2014-03-28 20:11 ` [PATCH 8/9] dm crypt: offload writes to thread Mike Snitzer
2014-04-01 16:27 ` Ondrej Kozina
2014-04-01 16:32 ` Mike Snitzer
2014-04-01 18:15 ` Mikulas Patocka
2014-04-01 18:23 ` Mike Snitzer
2014-04-02 6:55 ` Ondrej Kozina
2014-04-01 18:01 ` Mikulas Patocka
2014-04-01 19:08 ` Milan Broz
2014-03-28 20:11 ` [PATCH 9/9] dm crypt: sort writes Mike Snitzer
2014-03-29 8:11 ` Milan Broz
2014-03-31 12:39 ` Mike Snitzer
2014-03-31 23:37 ` Akira Hayakawa
2014-04-01 1:01 ` Mike Snitzer [this message]
2014-04-01 17:35 ` Milan Broz
2014-04-01 20:15 ` Alasdair G Kergon
2014-04-01 23:21 ` Akira Hayakawa
2014-04-02 3:19 ` Akira Hayakawa
2014-04-02 3:38 ` Mike Snitzer
2014-04-02 4:18 ` Akira Hayakawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401010129.GB9214@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=hayakawa@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.