From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH 2/2] ext4: Remove unneeded test of ret variable
Date: Tue, 1 Apr 2014 01:00:09 -0400 [thread overview]
Message-ID: <20140401050009.GN4911@thunk.org> (raw)
In-Reply-To: <1396257094-10386-2-git-send-email-lczerner@redhat.com>
On Mon, Mar 31, 2014 at 11:11:34AM +0200, Lukas Czerner wrote:
> Currently in ext4_fallocate() and ext4_zero_range() we're testing ret
> variable along with new_size. However in ext4_fallocate() we just tested
> ret before and in ext4_zero_range() if will always be zero when we get
> there so there is no need to test it in both cases.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Thanks, applied.
- Ted
next prev parent reply other threads:[~2014-04-01 5:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 9:11 [PATCH 1/2] ext4: Fix flag handling in ext4_split_convert_extents() Lukas Czerner
2014-03-31 9:11 ` [PATCH 2/2] ext4: Remove unneeded test of ret variable Lukas Czerner
2014-04-01 5:00 ` Theodore Ts'o [this message]
2014-03-31 14:12 ` [PATCH 1/2] ext4: Fix flag handling in ext4_split_convert_extents() Dmitry Monakhov
2014-03-31 14:19 ` Dan Carpenter
2014-04-01 4:57 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401050009.GN4911@thunk.org \
--to=tytso@mit.edu \
--cc=dan.carpenter@oracle.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.