From: Anders Darander <anders.darander@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: ft1000-usb: fixed a few code style issues
Date: Tue, 1 Apr 2014 08:34:44 +0200 [thread overview]
Message-ID: <20140401063444.GA10337@gmail.com> (raw)
In-Reply-To: <20140331225549.GA27227@kroah.com>
* Greg KH <gregkh@linuxfoundation.org> [140401 00:53]:
> On Mon, Mar 31, 2014 at 08:26:28AM +0200, Anders Darander wrote:
> > Fixed a few code style issues, particularly:
> > Add do {} while (0) wrapper around seq_* macros.
> > Change printk(KERN_WARN...) to netdev_warn(...).
> That's 2 different things, please split this up into 2 different
> patches.
Split up patches on their way.
> Remember, one patch does one thing.
Sure.
In this case I deemed them to be small and though not the same, but
still mosly coding style issues. Though, I can certainly see that the
printk to netdev_warn actually adds more than just a coding style
clean-up.
Cheers,
Anders
prev parent reply other threads:[~2014-04-01 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 6:26 [PATCH v2] Staging: ft1000-usb: fixed a few code style issues Anders Darander
2014-03-31 22:55 ` Greg KH
2014-04-01 6:34 ` Anders Darander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401063444.GA10337@gmail.com \
--to=anders.darander@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.