From: Martin Jansa <martin.jansa@gmail.com>
To: Florin Sarbu <florin.sarbu@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] libpcap.inc: Add PACKAGECONFIG support for bluez
Date: Tue, 1 Apr 2014 12:47:20 +0200 [thread overview]
Message-ID: <20140401104720.GK2425@jama> (raw)
In-Reply-To: <1396347400-9699-1-git-send-email-florin.sarbu@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]
On Tue, Apr 01, 2014 at 01:16:40PM +0300, Florin Sarbu wrote:
> This patch adds support for having bluez5 in PACKAGECONFIG
> and get libpcap DEPEND on bluez5.
>
> Signed-off-by: Florin Sarbu <florin.sarbu@windriver.com>
> ---
> meta/recipes-connectivity/libpcap/libpcap.inc | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-connectivity/libpcap/libpcap.inc b/meta/recipes-connectivity/libpcap/libpcap.inc
> index a984e05..1613567 100644
> --- a/meta/recipes-connectivity/libpcap/libpcap.inc
> +++ b/meta/recipes-connectivity/libpcap/libpcap.inc
> @@ -10,8 +10,9 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=1d4b0366557951c84a94fabe3529f867 \
> file://pcap.h;beginline=1;endline=34;md5=8d6cf7e17d5745010d633e30bc529ea9"
> DEPENDS = "flex-native bison-native libnl"
>
> -PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluetooth', '', d)}"
> -PACKAGECONFIG[bluetooth] = "--enable-bluetooth,--disable-bluetooth,bluez4"
> +PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'bluetooth', 'bluez4', '', d)}"
> +PACKAGECONFIG[bluez4] = "--enable-bluetooth,--disable-bluetooth,bluez4"
> +PACKAGECONFIG[bluez5] = "--enable-bluetooth,--disable-bluetooth,bluez5"
Does it work correctly?
If you don't enable both you will always get at least one
--disable-bluetooth and depending on order how packageconfigs were
processed it will be disabled or not.
> PACKAGECONFIG[canusb] = "--enable-canusb,--enable-canusb=no,libusb"
> PACKAGECONFIG[libnl1] = "--with-libnl,--without-libnl,libnl1,libnl1"
>
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2014-04-01 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 10:16 [PATCH] libpcap.inc: Add PACKAGECONFIG support for bluez Florin Sarbu
2014-04-01 10:47 ` Martin Jansa [this message]
2014-04-01 12:58 ` Florin Sarbu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401104720.GK2425@jama \
--to=martin.jansa@gmail.com \
--cc=florin.sarbu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.