All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, <netdev@vger.kernel.org>,
	<xen-devel@lists.xen.org>, <zoltan.kiss@citrix.com>,
	<edwin@etorok.net>, Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 net] xen-netback: disable rogue vif in kthread context
Date: Tue, 1 Apr 2014 12:44:28 +0100	[thread overview]
Message-ID: <20140401114428.GA6382@zion.uk.xensource.com> (raw)
In-Reply-To: <533AA4D4.10709@citrix.com>

On Tue, Apr 01, 2014 at 12:36:52PM +0100, David Vrabel wrote:
> On 01/04/14 12:33, Wei Liu wrote:
> > @@ -1574,6 +1575,16 @@ int xenvif_kthread(void *data)
> >  		wait_event_interruptible(vif->wq,
> >  					 rx_work_todo(vif) ||
> >  					 kthread_should_stop());
> 
> I think you're still missing a || vif->disabled from this wait_event
> conditional.
> 

Good catch. I will resubmit.

Wei.

> David

  reply	other threads:[~2014-04-01 11:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 11:33 [PATCH v3 net] xen-netback: disable rogue vif in kthread context Wei Liu
2014-04-01 11:36 ` David Vrabel
2014-04-01 11:44   ` Wei Liu [this message]
2014-04-01 11:44   ` Wei Liu
2014-04-01 11:36 ` David Vrabel
  -- strict thread matches above, loose matches on Subject: below --
2014-04-01 11:33 Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140401114428.GA6382@zion.uk.xensource.com \
    --to=wei.liu2@citrix.com \
    --cc=david.vrabel@citrix.com \
    --cc=edwin@etorok.net \
    --cc=ian.campbell@citrix.com \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    --cc=zoltan.kiss@citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.