All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-kernel@vger.kernel.org,
	"Greg KH" <gregkh@linuxfoundation.org>,
	driverdev-devel@linuxdriverproject.org,
	"Ezequiel García" <ezequiel@vanguardiasur.com.ar>,
	"Walter Lozano" <walter@vanguardiasur.com.ar>,
	"Forest Bond" <forest@alittletooquiet.net>
Subject: Re: [PATCH 3/3] staging: vt6655: fix checkpatch bracing issues
Date: Tue, 1 Apr 2014 11:19:42 -0300	[thread overview]
Message-ID: <20140401141942.GA8929@solid> (raw)
In-Reply-To: <20140401141302.GT6991@mwanda>

On Tue, Apr 01, 2014 at 05:13:02PM +0300, Dan Carpenter wrote:
> On Tue, Apr 01, 2014 at 09:52:13AM -0300, Guido Martínez wrote:
> > @@ -4285,14 +4252,9 @@ vMgrRxManagePacket(
> >  
> >  	case WLAN_FSTYPE_BEACON:
> >  		// Frame Clase = 0
> > -<<<<<<< HEAD
> > -		//DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO "rx beacon\n");
> > -		if (pMgmt->eScanState != WMAC_NO_SCANNING) {
> > -=======
> >  		if (pMgmt->eScanState != WMAC_NO_SCANNING)
> > ->>>>>>> f3c59ed... staging: vt6655: remove dead code
> >  			bInScan = true;
> > -		}
> > +
> >  		s_vMgrRxBeacon(pDevice, pMgmt, pRxPacket, bInScan);
> >  		break;
> >  
> > @@ -4357,16 +4319,11 @@ bMgrPrepareBeaconToSend(
> >  	PSDevice            pDevice = (PSDevice)hDeviceContext;
> >  	PSTxMgmtPacket      pTxPacket;
> >  
> > -<<<<<<< HEAD
> > -//    pDevice->bBeaconBufReady = false;
> > -	if (pDevice->bEncryptionEnable || pDevice->bEnable8021x) {
> > -=======
> >  	if (pDevice->bEncryptionEnable || pDevice->bEnable8021x)
> > ->>>>>>> f3c59ed... staging: vt6655: remove dead code
> >  		pMgmt->wCurrCapInfo |= WLAN_SET_CAP_INFO_PRIVACY(1);
> > -	} else {
> > +	else
> >  		pMgmt->wCurrCapInfo &= ~WLAN_SET_CAP_INFO_PRIVACY(1);
> > -	}
> > +
> 
> Wat?

I seem to have messed up my rebase. Sorry about that. I'll send a v2
fixing this and with your suggestions applied.

Thanks,

-- 
Guido Martínez, VanguardiaSur
www.vanguardiasur.com.ar

  reply	other threads:[~2014-04-01 14:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 12:52 [PATCH 0/3] staging: vt6655: style fixes Guido Martínez
2014-04-01 12:52 ` [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros Guido Martínez
2014-04-01 14:02   ` Dan Carpenter
2014-04-01 16:33   ` Greg KH
2014-04-01 16:56     ` Guido Martínez
2014-04-01 17:06       ` Greg KH
2014-04-01 12:52 ` [PATCH 2/3] staging: vt6655: remove dead code Guido Martínez
2014-04-01 14:19   ` Dan Carpenter
2014-04-01 12:52 ` [PATCH 3/3] staging: vt6655: fix checkpatch bracing issues Guido Martínez
2014-04-01 14:13   ` Dan Carpenter
2014-04-01 14:19     ` Guido Martínez [this message]
2014-04-02 17:53 ` [PATCH v2 0/4] staging: vt6655: style fixes Guido Martínez
2014-04-02 17:53   ` [PATCH v2 1/4] staging: vt6655: fix DBG_PRT and PRINT_K macros Guido Martínez
2014-04-02 17:53   ` [PATCH v2 2/4] staging: vt6655: remove mention of nonexistent function CARDbSetBasicRate Guido Martínez
2014-04-02 17:53   ` [PATCH v2 3/4] staging: vt6655: remove dead code Guido Martínez
2014-04-18 23:09     ` Greg KH
2014-04-19 19:43       ` Guido Martínez
2014-04-02 17:53   ` [PATCH v2 4/4] staging: vt6655: fix checkpatch bracing issues Guido Martínez
2014-04-02 18:09   ` [PATCH v2 0/4] staging: vt6655: style fixes Dan Carpenter
2014-04-03  0:15   ` Ezequiel García
2014-04-19 19:44   ` [PATCH v3 0/2] " Guido Martínez
2014-04-19 19:44     ` [PATCH v3 1/2] staging: vt6655: remove dead code Guido Martínez
2014-04-19 19:45     ` [PATCH v3 2/2] staging: vt6655: fix checkpatch bracing issues Guido Martínez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140401141942.GA8929@solid \
    --to=guido@vanguardiasur.com.ar \
    --cc=dan.carpenter@oracle.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=walter@vanguardiasur.com.ar \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.