All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 6/7] drm/i915: Fix framecount offset
Date: Wed, 2 Apr 2014 10:29:08 -0700	[thread overview]
Message-ID: <20140402102908.480cd93f@jbarnes-desktop> (raw)
In-Reply-To: <1396279290-29435-7-git-send-email-ville.syrjala@linux.intel.com>

On Mon, 31 Mar 2014 18:21:29 +0300
ville.syrjala@linux.intel.com wrote:

> From: Rafael Barbalho <rafael.barbalho@intel.com>
> 
> The framecount register was still using the old PIPE macro instead
> of the new PIPE2 macro
> 
> Signed-off-by: Rafael Barbalho <rafael.barbalho@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_reg.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index a47b4c3..b6441da 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3623,9 +3623,9 @@ enum punit_power_well {
>  #define   PIPE_PIXEL_MASK         0x00ffffff
>  #define   PIPE_PIXEL_SHIFT        0
>  /* GM45+ just has to be different */
> -#define _PIPEA_FRMCOUNT_GM45	(dev_priv->info.display_mmio_offset + 0x70040)
> -#define _PIPEA_FLIPCOUNT_GM45	(dev_priv->info.display_mmio_offset + 0x70044)
> -#define PIPE_FRMCOUNT_GM45(pipe) _PIPE(pipe, _PIPEA_FRMCOUNT_GM45, _PIPEB_FRMCOUNT_GM45)
> +#define _PIPEA_FRMCOUNT_GM45	0x70040
> +#define _PIPEA_FLIPCOUNT_GM45	0x70044
> +#define PIPE_FRMCOUNT_GM45(pipe) _PIPE2(pipe, _PIPEA_FRMCOUNT_GM45)
>  
>  /* Cursor A & B regs */
>  #define _CURACNTR		(dev_priv->info.display_mmio_offset + 0x70080)

Oh fun.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center

  reply	other threads:[~2014-04-02 17:27 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 15:21 [PATCH 0/7] drm/i915: Pile of display related patches ville.syrjala
2014-03-31 15:21 ` [PATCH 1/7] drm/i915: Refactor gmch hpd irq handling ville.syrjala
2014-03-31 15:49   ` Chris Wilson
2014-03-31 16:35     ` Ville Syrjälä
2014-03-31 16:56       ` Daniel Vetter
2014-03-31 20:57         ` Chris Wilson
2014-04-01  7:54     ` [PATCH v2 " ville.syrjala
2014-04-01  8:11       ` Chris Wilson
2014-04-01  8:15         ` Daniel Vetter
2014-03-31 15:21 ` [PATCH 2/7] drm/i915: Move DP M/N setup from update_pll to mode_set for gmch platforms ville.syrjala
2014-04-02 17:27   ` Jesse Barnes
2014-03-31 15:21 ` [PATCH 3/7] drm/i915: Split dp post_disable hooks ville.syrjala
2014-04-01  7:03   ` Jani Nikula
2014-04-01  7:37     ` Daniel Vetter
2014-03-31 15:21 ` [PATCH 4/7] drm/i915: Warn when DPIO read returns 0xffffffff ville.syrjala
2014-04-02 17:28   ` Jesse Barnes
2014-04-03  9:29   ` Daniel Vetter
2014-03-31 15:21 ` [PATCH 5/7] drm/i915: Provide a bit more info when pipestat bits are wrong ville.syrjala
2014-04-02 17:28   ` Jesse Barnes
2014-04-02 21:35   ` Damien Lespiau
2014-04-03 10:28     ` [PATCH v2 " ville.syrjala
2014-04-03 10:54       ` Damien Lespiau
2014-04-03 15:24         ` Daniel Vetter
2014-03-31 15:21 ` [PATCH 6/7] drm/i915: Fix framecount offset ville.syrjala
2014-04-02 17:29   ` Jesse Barnes [this message]
2014-04-03  9:30     ` Daniel Vetter
2014-04-03 11:04       ` Damien Lespiau
2014-04-03 15:26         ` Daniel Vetter
2014-03-31 15:21 ` [PATCH 7/7] drm/i915: Use enum plane instaad of numbers ville.syrjala
2014-03-31 17:31   ` Daniel Vetter
2014-03-31 17:33     ` Daniel Vetter
2014-03-31 18:29       ` [PATCH] drm/i915: Kill crtc->plane checks from the primary plane update hooks ville.syrjala
2014-03-31 20:37         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140402102908.480cd93f@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.