From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Antti Koskipaa <antti.koskipaa@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering
Date: Wed, 2 Apr 2014 14:21:59 +0300 [thread overview]
Message-ID: <20140402112159.GO21652@intel.com> (raw)
In-Reply-To: <1396436790-14313-6-git-send-email-antti.koskipaa@linux.intel.com>
On Wed, Apr 02, 2014 at 02:06:28PM +0300, Antti Koskipaa wrote:
<snip>
> @@ -184,9 +192,6 @@ static void test_crc_offscreen(test_data_t *test_data)
> do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top , bottom );
> do_test(test_data, left , right , top - (cursor_h+512), bottom + (cursor_h+512));
> do_test(test_data, left - (cursor_w+512), right + (cursor_w+512), top - (cursor_h+512), bottom + (cursor_h+512));
> -
> - /* go nuts */
> - do_test(test_data, INT_MIN, INT_MAX, INT_MIN, INT_MAX);
Why are you dropping the go nuts test? We had an actual bug in the
driver that this managed to hit. We should keep this test to avoid
regressions.
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-04-02 11:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 11:06 [PATCH i-g-t 0/7] kms_cursor_crc enhancements Antti Koskipaa
2014-04-02 11:06 ` [PATCH i-g-t 1/7] kms_cursor_crc: Remove some test cases and change cursor to color Antti Koskipaa
2014-04-02 11:06 ` [PATCH i-g-t 2/7] kms_cursor_crc: Move cursor enable and disable calls where they belong Antti Koskipaa
2014-04-02 11:06 ` [PATCH i-g-t 3/7] kms_cursor_crc: Use a function pointer to call test Antti Koskipaa
2014-04-02 11:06 ` [PATCH i-g-t 4/7] kms_cursor_crc: Separate onscreen and offscreen tests Antti Koskipaa
2014-04-02 11:06 ` [PATCH i-g-t 5/7] kms_cursor_crc: Add reference software rendering Antti Koskipaa
2014-04-02 11:21 ` Ville Syrjälä [this message]
2014-04-02 11:27 ` Antti Koskipää
2014-04-02 11:38 ` Ville Syrjälä
2014-04-02 11:06 ` [PATCH i-g-t 6/7] kms_cursor_crc: Add moving cursor test Antti Koskipaa
2014-04-02 11:06 ` [PATCH i-g-t 7/7] kms_cursor_crc: Add random cursor placement test Antti Koskipaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402112159.GO21652@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=antti.koskipaa@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.