From: Matthew Wilcox <willy@linux.intel.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/7] mpt3sas: Remove use of DEF_SCSI_QCMD
Date: Wed, 2 Apr 2014 09:20:14 -0400 [thread overview]
Message-ID: <20140402132014.GD5667@linux.intel.com> (raw)
In-Reply-To: <20140402104115.GB6510@infradead.org>
On Wed, Apr 02, 2014 at 03:41:15AM -0700, Christoph Hellwig wrote:
> On Thu, Mar 27, 2014 at 04:40:31PM -0400, Matthew Wilcox wrote:
> > Removing the host_lock from the I/O submission path gives a huge
> > scalability improvement.
>
> This looks reasonable to me, but did you do a full audit that all state
> is properly synchronized in the functions called from _scsih_qcmd_lck?
>
> If so that should be stated in the patch description.
I did one for mpt2sas back in July 2011 when I first submitted this patch.
http://marc.info/?l=linux-scsi&m=130980763617589&w=2
I must confess to having not done so for this iteration. The equivalent
to this patch has been in RHEL since 6.2, so I hope that gives us some
amount of confidence.
next prev parent reply other threads:[~2014-04-02 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 20:40 [PATCH 0/7] Performance improvements for LSI SCSI cards Matthew Wilcox
2014-03-27 20:40 ` [PATCH 1/7] mpt3sas: Remove uses of serial_number Matthew Wilcox
2014-04-02 10:39 ` Christoph Hellwig
2014-03-27 20:40 ` [PATCH 2/7] mpt3sas: Remove use of DEF_SCSI_QCMD Matthew Wilcox
2014-04-02 10:41 ` Christoph Hellwig
2014-04-02 13:20 ` Matthew Wilcox [this message]
2014-03-27 20:40 ` [PATCH 3/7] mpt2sas: Remove uses of serial_number Matthew Wilcox
2014-04-02 10:41 ` Christoph Hellwig
2014-03-27 20:40 ` [PATCH 4/7] mpt2sas: Remove use of DEF_SCSI_QCMD Matthew Wilcox
2014-03-27 20:40 ` [PATCH 5/7] mpt2sas: Add free smids to the head, not tail of list Matthew Wilcox
2014-04-02 10:41 ` Christoph Hellwig
2014-03-27 20:40 ` [PATCH 6/7] fusion: Add free msg frames " Matthew Wilcox
2014-04-02 10:42 ` Christoph Hellwig
2014-03-27 20:40 ` [PATCH 7/7] fusion: Remove use of DEF_SCSI_QCMD Matthew Wilcox
2014-03-31 5:54 ` [PATCH 0/7] Performance improvements for LSI SCSI cards Nicholas A. Bellinger
2014-04-02 8:06 ` Desai, Kashyap
2014-04-02 22:28 ` Krishnamoorthy, Praveen
2014-04-07 11:51 ` Reddy, Sreekanth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402132014.GD5667@linux.intel.com \
--to=willy@linux.intel.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.