From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver Date: Wed, 2 Apr 2014 16:16:54 +0100 Message-ID: <20140402151654.GA24060@lee--X1> References: <1395744293-24398-1-git-send-email-rogerable@realtek.com> <1395744293-24398-4-git-send-email-rogerable@realtek.com> <533A3080.2020008@realtek.com> <20140401150654.fe27636428a62fdf9e0d2dc1@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20140401150654.fe27636428a62fdf9e0d2dc1@linux-foundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org To: Andrew Morton Cc: Ulf Hansson , Maxim Levitsky , Alex Dubov , Greg Kroah-Hartman , driverdev-devel@linuxdriverproject.org, linux-mmc@vger.kernel.org, Chris Ball , linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn, Roger , Dan Carpenter , Samuel Ortiz List-Id: linux-mmc@vger.kernel.org T24gVHVlLCAwMSBBcHIgMjAxNCwgQW5kcmV3IE1vcnRvbiB3cm90ZToKCj4gT24gVHVlLCAxIEFw ciAyMDE0IDExOjIwOjMyICswODAwIFJvZ2VyIDxyb2dlcmFibGVAcmVhbHRlay5jb20+IHdyb3Rl Ogo+IAo+ID4gT24gMDMvMjUvMjAxNCAwNjo0NCBQTSwgcm9nZXJhYmxlQHJlYWx0ZWsuY29tIHdy b3RlOgo+ID4gPiBGcm9tOiBSb2dlciBUc2VuZyA8cm9nZXJhYmxlQHJlYWx0ZWsuY29tPgo+ID4g Pgo+ID4gPiBSZWFsdGVrIFVTQiBtZW1zdGljayBob3N0IGRyaXZlciBwcm92aWRlcyBtZW1zdGlj ayBob3N0IHN1cHBvcnQgYmFzZWQgb24gdGhlCj4gPiA+IFJlYWx0ZWsgVVNCIGNhcmQgcmVhZGVy IE1GRCBkcml2ZXIuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFRzZW5nIDxyb2dl cmFibGVAcmVhbHRlay5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgIGRyaXZlcnMvbWVtc3RpY2svaG9z dC9LY29uZmlnICAgICAgIHwgIDEwICsKPiA+ID4gICBkcml2ZXJzL21lbXN0aWNrL2hvc3QvTWFr ZWZpbGUgICAgICB8ICAgMSArCj4gPiA+ICAgZHJpdmVycy9tZW1zdGljay9ob3N0L3J0c3hfdXNi X21zLmMgfCA4MzkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiA+ICAg MyBmaWxlcyBjaGFuZ2VkLCA4NTAgaW5zZXJ0aW9ucygrKQo+ID4gPiAgIGNyZWF0ZSBtb2RlIDEw MDY0NCBkcml2ZXJzL21lbXN0aWNrL2hvc3QvcnRzeF91c2JfbXMuYwo+ID4gSGkgQW5kcmV3LAo+ ID4gCj4gPiBTaW5jZSBJJ2xsIGhhdmUgdG8gc2VuZCBuZXh0IHJldmlzaW9uKHY2LCB0byBtb2Rp ZnkgcGF0Y2ggMS8zKSBhbmQgCj4gPiB5b3UndmUgY29tbWVudGVkIHY0LCB3b3VsZCB5b3UgYWxz byBjb21tZW50IG9yIEFjayB0aGUgMy8zIG9mIHRoaXMgb25lPyAKPiA+IFRoaXMgc2hvdWxkIHNh dmUgb25lIHJldmlzaW9uIGZvciBtZSB0byBtYWtlIGFueSBuZWNlc3NhcnkgY2hhbmdlLgo+IAo+ IEl0IGxvb2tzIE9LIHRvIG15IGluZXhwZXJ0IGV5ZS4gIEl0IHdvdWxkIGJlIGJldHRlciBpZiBN YXhpbSBhbmQvb3IgQWxleAo+IGNvdWxkIHJldmlldyB0aGUgY29kZS4gIElmIHRoYXQgZG9lc24n dCBoYXBwZW4gdGhlbiBJIGd1ZXNzIHRoZSBiZXN0IHdlCj4gY2FuIGRvIGlzIHRvIGdvIGFoZWFk IGFuZCBtZXJnZSBpdC4gIEhhdmUgeW91IHdvcmtlZCBvdXQgdmlhIHdoaWNoIHRyZWUKPiB0aGUg cGF0Y2hlcyB3aWxsIGJlIG1lcmdlZD8KCkknbGwgYmUgaGFwcHkgdG8gdGFrZSB0aGUgc2V0IGlm IG9uZSBvZiB0aGUgc3Vic3lzdGVtIGV4cGVydHMgd291bGQgYmUKa2luZCBlbm91Z2ggdG8gY2Fz dCBhbiBleWUgb3ZlciBpdC4KCk1heGltLCBBbGV4PwoKLS0gCkxlZSBKb25lcwpMaW5hcm8gU1RN aWNyb2VsZWN0cm9uaWNzIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291 cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0 ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRldmVsIG1haWxpbmcgbGlzdApkZXZlbEBsaW51eGRyaXZlcnByb2plY3Qub3JnCmh0dHA6Ly9k cml2ZXJkZXYubGludXhkcml2ZXJwcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaXZlcmRl di1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932318AbaDBPRN (ORCPT ); Wed, 2 Apr 2014 11:17:13 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:47023 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbaDBPRM (ORCPT ); Wed, 2 Apr 2014 11:17:12 -0400 Date: Wed, 2 Apr 2014 16:16:54 +0100 From: Lee Jones To: Andrew Morton Cc: Roger , Samuel Ortiz , Chris Ball , Greg Kroah-Hartman , Maxim Levitsky , Alex Dubov , Dan Carpenter , Ulf Hansson , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, driverdev-devel@linuxdriverproject.org, wei_wang@realsil.com.cn, micky_ching@realsil.com.cn Subject: Re: [PATCH v5 3/3] memstick: Add realtek USB memstick host driver Message-ID: <20140402151654.GA24060@lee--X1> References: <1395744293-24398-1-git-send-email-rogerable@realtek.com> <1395744293-24398-4-git-send-email-rogerable@realtek.com> <533A3080.2020008@realtek.com> <20140401150654.fe27636428a62fdf9e0d2dc1@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140401150654.fe27636428a62fdf9e0d2dc1@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 01 Apr 2014, Andrew Morton wrote: > On Tue, 1 Apr 2014 11:20:32 +0800 Roger wrote: > > > On 03/25/2014 06:44 PM, rogerable@realtek.com wrote: > > > From: Roger Tseng > > > > > > Realtek USB memstick host driver provides memstick host support based on the > > > Realtek USB card reader MFD driver. > > > > > > Signed-off-by: Roger Tseng > > > --- > > > drivers/memstick/host/Kconfig | 10 + > > > drivers/memstick/host/Makefile | 1 + > > > drivers/memstick/host/rtsx_usb_ms.c | 839 ++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 850 insertions(+) > > > create mode 100644 drivers/memstick/host/rtsx_usb_ms.c > > Hi Andrew, > > > > Since I'll have to send next revision(v6, to modify patch 1/3) and > > you've commented v4, would you also comment or Ack the 3/3 of this one? > > This should save one revision for me to make any necessary change. > > It looks OK to my inexpert eye. It would be better if Maxim and/or Alex > could review the code. If that doesn't happen then I guess the best we > can do is to go ahead and merge it. Have you worked out via which tree > the patches will be merged? I'll be happy to take the set if one of the subsystem experts would be kind enough to cast an eye over it. Maxim, Alex? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog