Re: [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Peter Maydell (peter.maydell@linaro.org) wrote:
> The datasheet is clear that the frame length written to the DATA
> register is actually stored in the TX FIFO; this means we don't
> need to keep both tx_frame_len and tx_fifo_len state separately.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---

> -    register_savevm(dev, "stellaris_enet", -1, 1,
> +    register_savevm(dev, "stellaris_enet", -1, 2,
>                      stellaris_enet_save, stellaris_enet_load, s);
>      return 0;

Note that as well as inc'ing that you would have to change the
    if (version_id != 1)

in stellaris_enet_load (if you weren't about to scrap the load/save
code anyway).

Dave

>  }
> -- 
> 1.9.0
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK