Re: [Qemu-devel] [PATCH] qemu-thread-posix: Fix build against older glibc version

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Ed Maste (emaste@freebsd.org) wrote:
> On 11 March 2014 12:13, Dr. David Alan Gilbert <dgilbert@redhat.com> wrote:
> 
> > Except pthread_setname_np is not portable and was previously
> > ifdef'd _GNU_SOURCE anyway, and the parameters on other OSs
> > maybe different (freebsd has got a 3rd parameter for no
> > apparent reason).
> 
> No, glibc's arguments are identical to FreeBSD's.  The difference is
> that it's pthread_set_name_np (with an extra underscore).
> 
> FreeBSD: void pthread_set_name_np(pthread_t, const char *);
> glibc: int pthread_setname_np(pthread_t, const char *);
> NetBSD: int pthread_setname_np(pthread_t, const char *, void *);
> Darwin: pthread_setname_np(const char *);

Ah, apologies - I got the wrong *BSD for the 3rd argument stuff.
Anyway, feel free to add your favorite OS to the configure check/use.

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK