Re: [v7] ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate

[Theodore Ts'o <tytso@mit.edu>]

Some final testing luckily caught a bug in your patch.  I'll fix it
up, but for future reference, it's important to check to see if the
handle is valid (i.e., we are not in no-journal mode) before using any
of the journalling functions.  Otherwise, you will crash if you try
using the code path when the file system does not have a journal.

BTW, I would strongly recommend using the automated regression test
system found at:

	git://git.kernel.org/pub/scm/fs/ext2/xfstests-bld.git

It finds these sorts of problems very quickly.  After you build a
kernel, running "kvm-xfstests -g quick" would have found the problem
very quickly.  The fastest reproducer for the bug that I found is:
"kvm-xfstests -c nojournal shared/001".

Cheers,

						- Ted

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 7015917..bbba1ef 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4902,6 +4902,9 @@ ext4_access_path(handle_t *handle, struct inode *inode,
 {
 	int credits, err;
 
+	if (!ext4_handle_valid(handle))
+		return 0;
+
 	/*
 	 * Check if need to extend journal credits
 	 * 3 for leaf, sb, and inode plus 2 (bmap and group