From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>, Jean Delvare <jdelvare@suse.de>,
Struan Bartlett <struan.bartlett@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
gnomes@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ttyprintk: Allow built as a module
Date: Wed, 2 Apr 2014 12:32:22 -0700 [thread overview]
Message-ID: <20140402193222.GA26425@kroah.com> (raw)
In-Reply-To: <1396434582-30799-2-git-send-email-tiwai@suse.de>
On Wed, Apr 02, 2014 at 12:29:42PM +0200, Takashi Iwai wrote:
> The driver is well written to be used as a module, just the exit call
> is missing.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> drivers/char/Kconfig | 2 +-
> drivers/char/ttyprintk.c | 13 ++++++++++++-
> 2 files changed, 13 insertions(+), 2 deletions(-)
There was some reason we didn't do this back when the code was accepted,
but I really can't remember why.
If you have tested this out, I don't have any objections to taking these
patches, thanks.
greg k-h
next prev parent reply other threads:[~2014-04-02 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 10:29 [PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path Takashi Iwai
2014-04-02 10:29 ` [PATCH 2/2] ttyprintk: Allow built as a module Takashi Iwai
2014-04-02 12:31 ` Jean Delvare
2014-04-02 12:42 ` Takashi Iwai
2014-04-02 19:32 ` Greg Kroah-Hartman [this message]
2014-04-03 6:13 ` Takashi Iwai
2014-04-05 11:15 ` Samo Pogačnik
2014-04-02 12:24 ` [PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call in the error path Jean Delvare
2014-04-03 6:10 ` Takashi Iwai
2014-04-03 8:00 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402193222.GA26425@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@linux-m68k.org \
--cc=struan.bartlett@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.