From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WVOml-0004Q0-Ou for mharc-grub-devel@gnu.org; Wed, 02 Apr 2014 13:17:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOma-0004Id-Ql for grub-devel@gnu.org; Wed, 02 Apr 2014 13:17:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVOmR-0008Mi-QB for grub-devel@gnu.org; Wed, 02 Apr 2014 13:17:00 -0400 Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:43544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOmR-0008MX-IR for grub-devel@gnu.org; Wed, 02 Apr 2014 13:16:51 -0400 Received: by mail-la0-f41.google.com with SMTP id gl10so425505lab.0 for ; Wed, 02 Apr 2014 10:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=zNnJDZ0FW5U9o51N8tDv3LEfLouoTDodB7A939RdAjY=; b=T2QtLhHMshBSpmaYfeTBTLUCCbXde0B8/2DoGM63OLUFtn3i/OUQk/vAs0ozuZx2kU ncmPL46ch2W8ug2kcxqqkruHLCSl9i+LWIKHoO5x2gk6oNq/rdOAmiTop1jARIGE/l2s SbCoa/8m4VGHrkXrgIecZ8u5iBwZ/zBy4UZehACowBmE3ozrbOdux20L4oVg87oQrjnc 7xcK0/Pbg+KxaKPL4CmjwChnTXHp5AED3Y9XMyHIow22eQA4XWoCsFE7lmO2/COdmX3t Elj3g2R3+Ybrz54lPowZmVef0s9fKQqxCPxHcKyH8Wig4pRWAUzzJ09kBciWNzXgz+QZ e06g== X-Received: by 10.152.19.7 with SMTP id a7mr632056lae.16.1396459010134; Wed, 02 Apr 2014 10:16:50 -0700 (PDT) Received: from opensuse.site (ppp37-190-15-130.pppoe.spdop.ru. [37.190.15.130]) by mx.google.com with ESMTPSA id x5sm1774549lbk.5.2014.04.02.10.16.49 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 02 Apr 2014 10:16:49 -0700 (PDT) Date: Wed, 2 Apr 2014 21:16:48 +0400 From: Andrey Borzenkov To: Ram Pai Subject: Re: [RFC PATCH 20/23] fix parameter to firmware calls Message-ID: <20140402211648.5a5b6974@opensuse.site> In-Reply-To: <20140402170832.GE29218@ram.oc3035372033.ibm.com> References: <1393439482-20341-1-git-send-email-linuxram@us.ibm.com> <1393439482-20341-21-git-send-email-linuxram@us.ibm.com> <20140401214535.324d3162@opensuse.site> <20140402170832.GE29218@ram.oc3035372033.ibm.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::229 Cc: The development of GNU GRUB , anton@au1.ibm.com, tlfalcon@linux.vnet.ibm.com, tbberry@us.ibm.com, tonyb@au1.ibm.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 17:17:10 -0000 В Wed, 2 Apr 2014 10:08:32 -0700 Ram Pai пишет: > On Tue, Apr 01, 2014 at 09:45:35PM +0400, Andrey Borzenkov wrote: > > В Wed, 26 Feb 2014 10:31:19 -0800 > > Ram Pai пишет: > > > > > -#define IEEE1275_ADDR(x) (grub_uint32_t)(grub_addr_t)(x) > > > - > > > +#define IEEE1275_ADDR(x) (grub_uint32_t)grub_cpu_to_be32((grub_addr_t)(x)) > > > +#define IEEE1275_VALUE(x) (grub_uint32_t)grub_cpu_to_be32(x) > > > > Same question - what about sparc64, is it safe to truncate values there? > > dont know anything about sparc64. Probably not. > > These macros are used only for the powerpc specific code AFAICT. Files under grub-core/*/ieee1275 are used for ieee1275 platforms, which include sparc64 (and actually i385 as well, so you need to check how it affects these too) GROUPS["ieee1275"] = [ "i386_ieee1275", "sparc64_ieee1275", "powerpc_ieee1275" ] > I will audit and confirm. > >