From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WVPPT-0004WJ-9V for mharc-grub-devel@gnu.org; Wed, 02 Apr 2014 13:57:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVPPM-0004W8-JD for grub-devel@gnu.org; Wed, 02 Apr 2014 13:57:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVPPF-0007xt-Dq for grub-devel@gnu.org; Wed, 02 Apr 2014 13:57:04 -0400 Received: from mail-la0-x232.google.com ([2a00:1450:4010:c03::232]:41758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVPPF-0007xh-6B for grub-devel@gnu.org; Wed, 02 Apr 2014 13:56:57 -0400 Received: by mail-la0-f50.google.com with SMTP id pv20so448848lab.37 for ; Wed, 02 Apr 2014 10:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=G/qZaPqUq1J17d756rGXZ35zUXQWP6AOKJRairrAAdI=; b=O34dNBDfps/jViS0Y79KfAQUco8AgocAJoVr8gVpKjqTHrx74G+V8pyTqMstzuLhCP 5gtCtnvlkLdY/IaSwacPKHv/Vy15HixQjkuPJpIzaffSzZKICMtkwOXcnki3Sdbjv5NZ Hx/HDSCHrw+69/jWIV7R2FjH/sw5q6pJ30vC/rg87Sk7/CGmFoRsSF/jC8kMmNRkcsAf nwEn7re0DG4QvUdJdPtA5AxiQlSEscLJWU84E1oQqKcFeoecPN/YjLZYU1Wo7q3dbS/q 2EZRB7a0w2pjYcLJ8Xe1qeNKQFuT7eLBHm3GKxhi6CwPEeElsNU2cBjlux1XZxX15o3D HQWw== X-Received: by 10.112.241.73 with SMTP id wg9mr880532lbc.48.1396461416036; Wed, 02 Apr 2014 10:56:56 -0700 (PDT) Received: from opensuse.site (ppp37-190-15-130.pppoe.spdop.ru. [37.190.15.130]) by mx.google.com with ESMTPSA id mk5sm2519007lac.6.2014.04.02.10.56.54 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 02 Apr 2014 10:56:55 -0700 (PDT) Date: Wed, 2 Apr 2014 21:56:54 +0400 From: Andrey Borzenkov To: Ram Pai Subject: Re: [RFC PATCH 11/23] Fix powerpc setjmp/longjmp 64bit issues Message-ID: <20140402215654.05c67265@opensuse.site> In-Reply-To: <20140402174834.GG29218@ram.oc3035372033.ibm.com> References: <1393439482-20341-1-git-send-email-linuxram@us.ibm.com> <1393439482-20341-12-git-send-email-linuxram@us.ibm.com> <20140401212719.30c3d1f9@opensuse.site> <20140402170605.GD29218@ram.oc3035372033.ibm.com> <20140402211959.001bb882@opensuse.site> <20140402174834.GG29218@ram.oc3035372033.ibm.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::232 Cc: The development of GNU GRUB , tlfalcon@linux.vnet.ibm.com, tbberry@us.ibm.com, anton@au1.ibm.com, tonyb@au1.ibm.com, Anton Blanchard X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 17:57:10 -0000 В Wed, 2 Apr 2014 10:48:34 -0700 Ram Pai пишет: > On Wed, Apr 02, 2014 at 09:19:59PM +0400, Andrey Borzenkov wrote: > > В Wed, 2 Apr 2014 10:06:05 -0700 > > Ram Pai пишет: > > > > > On Tue, Apr 01, 2014 at 09:27:19PM +0400, Andrey Borzenkov wrote: > > > > В Wed, 26 Feb 2014 10:31:10 -0800 > > > > Ram Pai пишет: > > > > > > > > > From: Anton Blanchard > > > > > > > > > > Fix powerpc setjmp/longjmp 64bit issues > > > > > > > > > > Signed-off-by: Ram Pai > > > > > From: Anton Blanchard > > > > > --- > > > > > grub-core/lib/powerpc/setjmp.S | 94 +++++++++++++++++++++++------------------- > > > > > 1 file changed, 52 insertions(+), 42 deletions(-) > > > > > > > > > > diff --git a/grub-core/lib/powerpc/setjmp.S b/grub-core/lib/powerpc/setjmp.S > > > > > index 716b563..51fcae9 100644 > > > > > --- a/grub-core/lib/powerpc/setjmp.S > > > > > +++ b/grub-core/lib/powerpc/setjmp.S > > > > > @@ -25,33 +25,43 @@ GRUB_MOD_LICENSE "GPLv3+" > > > > > > > > > > .text > > > > > > > > > > +#if defined( __powerpc64__ ) || defined( __powerpc64le__ ) > > > > > > > > Where is __powerpc64__ defined? Your previous patch adds only > > > > __powerpc64le__ and it does exist in current code as well? > > > > > > It is already defined even prior to this patch series. > > > > Where? > > just checked. Looks like it is defined automatically by the compiler automatically when -m64 is > specified. > grub does not use -m64 on powerpc. Existing target is 32 bit.