All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: capri: make Kconfig dependency more strict
Date: Thu, 3 Apr 2014 10:01:02 +0200	[thread overview]
Message-ID: <20140403080102.GE29751@pengutronix.de> (raw)
In-Reply-To: <533C9B1E.6020905@broadcom.com>

Hello,

On Wed, Apr 02, 2014 at 04:19:58PM -0700, Sherman Yin wrote:
> On 14-04-01 01:10 PM, Uwe Kleine-K?nig wrote:
> >This driver is only useful on BCM281xx, so let the driver depend on
> >ARCH_BCM_MOBILE but allow compile coverage testing.
> >The main benefit is that the driver isn't available to be selected for
> >machines that don't have the matching hardware.
> >
> >Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> >---
> >  drivers/pinctrl/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> >index e49324032611..072749816cb4 100644
> >--- a/drivers/pinctrl/Kconfig
> >+++ b/drivers/pinctrl/Kconfig
> >@@ -106,7 +106,7 @@ config PINCTRL_BCM2835
> >
> >  config PINCTRL_CAPRI
> >  	bool "Broadcom Capri pinctrl driver"
> >-	depends on OF
> >+	depends on OF && (ARCH_BCM_MOBILE || COMPILE_TEST)
> >  	select PINMUX
> >  	select PINCONF
> >  	select GENERIC_PINCONF
> >
> 
> Looks good. Just wondering how you've come across this driver (and
> PINCTRL_MSM8X74)?
Well, I was annoyed by being asked if I want to enable them for my efm32
machine during make oldconfig after updating the kernel. :-)

> Reviewed-by: Sherman Yin <syin@broadcom.com>
Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2014-04-03  8:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-01 20:10 [PATCH] pinctrl: capri: make Kconfig dependency more strict Uwe Kleine-König
2014-04-02 23:19 ` Sherman Yin
2014-04-03  8:01   ` Uwe Kleine-König [this message]
2014-04-10 16:55 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403080102.GE29751@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.