From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jimmy Li <coder.liss@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Teodora Baluta" <teobaluta@gmail.com>,
"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@intel.com>,
"Michael Gunselmann" <michael.gunselmann@studium.uni-erlangen.de>,
"Lisa Nguyen" <lisa@xenapiadmin.com>,
"Martin Hofmann" <martin.hofmann@studium.uni-erlangen.de>,
"Malcolm Priestley" <tvboxspy@gmail.com>,
"Tülin İzer" <tulinizer@gmail.com>,
"Archana kumari" <archanakumari959@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning
Date: Thu, 3 Apr 2014 12:04:51 +0300 [thread overview]
Message-ID: <20140403090451.GE6991@mwanda> (raw)
In-Reply-To: <20140328032844.GC2263@gmail.com>
On Thu, Mar 27, 2014 at 08:28:44PM -0700, Jimmy Li wrote:
> You are right, I found that variable buf also don't make sense here,
> maybe this could be more clear.
>
> param = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL);
> if (param == NULL)
> return -ENOMEM;
>
> removing two unnecessary variable, buf and blen.
>
> In this situation, I should send a new patch v2 for it base on the
> previous path? or send a new patch include all changes?
We throw away the original patch and you send a v2. Use the subject:
[PATCH v2] drivers/staging/vt6655/iwctl.c fix a sparse warning
Under the Signed-off-by line put:
Signed-off-by: you
---
v2: additional cleanups as well.
regards,
dan carpenter
prev parent reply other threads:[~2014-04-03 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 7:42 [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning Jimmy Li
2014-03-26 12:10 ` Greg Kroah-Hartman
2014-03-26 15:16 ` Joe Perches
2014-03-28 3:28 ` Jimmy Li
2014-04-03 9:04 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403090451.GE6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=archanakumari959@gmail.com \
--cc=coder.liss@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lisa@xenapiadmin.com \
--cc=martin.hofmann@studium.uni-erlangen.de \
--cc=michael.gunselmann@studium.uni-erlangen.de \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=teobaluta@gmail.com \
--cc=tulinizer@gmail.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.