All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
	lgirdwood@gmail.com, timur@tabi.org
Subject: Re: [PATCH 4/4] ASoC: spdif: Add Vybird and LS1+ compatibles support.
Date: Thu, 3 Apr 2014 20:45:15 +0800	[thread overview]
Message-ID: <20140403124514.GA32327@MrMyself> (raw)
In-Reply-To: <1396516257-25354-5-git-send-email-Li.Xiubo@freescale.com>

On Thu, Apr 03, 2014 at 05:10:57PM +0800, Xiubo Li wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
>  sound/soc/fsl/fsl_spdif.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
> index 173553c..5c958ca 100644
> --- a/sound/soc/fsl/fsl_spdif.c
> +++ b/sound/soc/fsl/fsl_spdif.c
> @@ -1186,6 +1186,8 @@ static int fsl_spdif_probe(struct platform_device *pdev)
>  
>  static const struct of_device_id fsl_spdif_dt_ids[] = {
>  	{ .compatible = "fsl,imx35-spdif", },
> +	{ .compatible = "fsl,vybird-spdif", },
> +	{ .compatible = "fsl,ls1+-spdif", },

Same comments here.

And just a little reminder:
You are using "fsl,vf610-sai" for fsl_sai.c. I was wondering if you'd better
use "fsl,vf610-spdif" over here as well.

Best regards,
Nicolin

>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, fsl_spdif_dt_ids);
> -- 
> 1.8.4
> 
> 

  reply	other threads:[~2014-04-03 13:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03  9:10 [PATCH 0/4] Add ESAI & SPDIF Vybird and LS1+ support Xiubo Li
2014-04-03  9:10 ` [PATCH 1/4] ASoC: esai: fix buggy of 'ret' type definition Xiubo Li
2014-04-03 10:50   ` Nicolin Chen
2014-04-03  9:10 ` [PATCH 2/4] ASoC: esai: Add Vybird and LS1+ compatibles support Xiubo Li
2014-04-03 11:19   ` Nicolin Chen
2014-04-04  0:46     ` Li.Xiubo
2014-04-03  9:10 ` [PATCH 3/4] ASoC: spdif: Sort the header files alphabetically Xiubo Li
2014-04-03 11:21   ` Nicolin Chen
2014-04-03  9:10 ` [PATCH 4/4] ASoC: spdif: Add Vybird and LS1+ compatibles support Xiubo Li
2014-04-03 12:45   ` Nicolin Chen [this message]
2014-04-04  0:41     ` Li.Xiubo
2014-04-03 14:46   ` Fabio Estevam
2014-04-04  0:40     ` Li.Xiubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140403124514.GA32327@MrMyself \
    --to=guangyu.chen@freescale.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.