From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbaDCQer (ORCPT ); Thu, 3 Apr 2014 12:34:47 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:58313 "EHLO e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752713AbaDCQei (ORCPT ); Thu, 3 Apr 2014 12:34:38 -0400 Date: Thu, 3 Apr 2014 22:04:30 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ingo Molnar , Ananth N Mavinakayanahalli , David Long , Denys Vlasenko , "Frank Ch. Eigler" , Jim Keniston , Jonathan Lebon , Masami Hiramatsu , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] uprobes/x86: move the UPROBE_FIX_{RIP,IP,CALL} code at the end of pre/post hooks Message-ID: <20140403163430.GD4882@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20140331194337.GA9257@redhat.com> <20140331194412.GA9304@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20140331194412.GA9304@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14040316-6102-0000-0000-00000540B308 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Oleg Nesterov [2014-03-31 21:44:12]: > No functional changes. Preparation to simplify the review of the next > change. Just reorder the code in arch_uprobe_pre/post_xol() functions > so that UPROBE_FIX_{RIP_*,IP,CALL} logic goes to the end. > > Also change arch_uprobe_pre_xol() to use utask instead of autask, to > make the code more symmetrical with arch_uprobe_post_xol(). > > Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju