From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 06/11] libao: Remove OSS plugin when ALSA is enabled
Date: Thu, 3 Apr 2014 23:37:03 +0200 [thread overview]
Message-ID: <20140403213703.GF17328@free.fr> (raw)
In-Reply-To: <1396558881-29631-6-git-send-email-paul@crapouillou.net>
Paul, Maarten, All,
On 2014-04-03 23:01 +0200, Paul Cercueil spake thusly:
> From: Maarten ter Huurne <maarten@treewalker.org>
>
> At runtime, libao will load all plugins, even ones that will never be used.
> Since libao will prefer ALSA over OSS by default anyway, it is pretty safe
> to exclude the OSS plugin.
>
> There is no configure option for disabling the OSS plugin, so we remove
> the shared object in a post-install hook.
>
> Signed-Off-By: Maarten ter Huurne <maarten@treewalker.org>
> Acked-By: Paul Cercueil <paul@crapouillou.net>
> ---
> package/libao/libao.mk | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/package/libao/libao.mk b/package/libao/libao.mk
> index 8e9ee35..e6704f2 100644
> --- a/package/libao/libao.mk
> +++ b/package/libao/libao.mk
> @@ -11,11 +11,16 @@ LIBAO_INSTALL_STAGING = YES
> LIBAO_LICENSE = GPLv2+
> LIBAO_LICENSE_FILES = COPYING
> LIBAO_CONF_OPT = --disable-esd --disable-wmm --disable-arts \
> - --disable-nas --disable-pulse
> + --disable-nas --disable-pulse --disable-broken-oss
> +
> +define LIBAO_REMOVE_OSS_PLUGIN
> + rm -f $(TARGET_DIR)/usr/lib/ao/plugins-4/liboss.so
> +endef
>
> ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
> LIBAO_DEPENDENCIES += alsa-lib
> LIBAO_CONF_OPT += --enable-alsa --enable-alsa-mmap
Please define the hook at the place it's going to be used, that is, here.
See:
http://nightly.buildroot.org/#_coding_style
Regards,
Yann E. MORIN.
> +LIBAO_POST_INSTALL_TARGET_HOOKS += LIBAO_REMOVE_OSS_PLUGIN
> else
> LIBAO_CONF_OPT += --disable-alsa
> endif
> --
> 1.9.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-04-03 21:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 21:01 [Buildroot] [PATCH 01/11] toolchain: Make vendor configurable Paul Cercueil
2014-04-03 21:01 ` [Buildroot] [PATCH 02/11] arch: MIPS: Add config option BR2_GCC_TARGET_TUNE Paul Cercueil
2014-04-03 21:19 ` Yann E. MORIN
2014-04-03 21:50 ` Paul Cercueil
2014-04-03 22:12 ` Yann E. MORIN
2014-04-05 15:53 ` Paul Cercueil
2014-04-05 16:47 ` Yann E. MORIN
2014-04-07 13:53 ` Markos Chandras
2014-04-03 21:01 ` [Buildroot] [PATCH 03/11] gdb: Patch for "unrecognized real-time signal" bug Paul Cercueil
2014-10-12 14:06 ` Vincent Olivert Riera
2014-10-12 15:57 ` Thomas Petazzoni
2014-04-03 21:01 ` [Buildroot] [PATCH 04/11] gdb: Fix on-target threads debugging Paul Cercueil
2014-04-03 21:23 ` Yann E. MORIN
2014-04-03 21:01 ` [Buildroot] [PATCH 05/11] dialog: Patch incorrect use of toupper() Paul Cercueil
2014-04-03 21:32 ` Yann E. MORIN
2014-04-04 6:45 ` Arnout Vandecappelle
2014-04-08 16:56 ` Paul Cercueil
2014-04-10 8:40 ` Thomas De Schampheleire
2014-04-10 9:44 ` Arnout Vandecappelle
2014-07-19 14:06 ` Thomas De Schampheleire
2014-08-15 23:00 ` Paul Cercueil
2014-04-03 21:01 ` [Buildroot] [PATCH 06/11] libao: Remove OSS plugin when ALSA is enabled Paul Cercueil
2014-04-03 21:37 ` Yann E. MORIN [this message]
2014-04-03 21:01 ` [Buildroot] [PATCH 07/11] fmtools: Switch to 2.x series Paul Cercueil
2014-04-03 21:45 ` Yann E. MORIN
2014-04-06 13:26 ` Thomas Petazzoni
2014-04-03 21:01 ` [Buildroot] [PATCH 08/11] python-pygame: Make installation of examples optional Paul Cercueil
2014-04-03 21:48 ` Yann E. MORIN
2014-04-04 6:14 ` Arnout Vandecappelle
2014-04-03 21:01 ` [Buildroot] [PATCH 09/11] util-linux: Add config switches for some more binaries Paul Cercueil
2014-04-03 21:55 ` Yann E. MORIN
2014-04-03 22:00 ` Paul Cercueil
2014-04-03 21:01 ` [Buildroot] [PATCH 10/11] luajit: Allow to build on Mips and Mipsel platforms Paul Cercueil
2014-04-04 21:41 ` Thomas Petazzoni
2014-04-03 21:01 ` [Buildroot] [PATCH 11/11] stress: Patch to fix documentation source Paul Cercueil
2014-04-03 21:12 ` [Buildroot] [PATCH 01/11] toolchain: Make vendor configurable Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403213703.GF17328@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.