From: Thierry Reding <thierry.reding@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: linux-pwm@vger.kernel.org, 'Eric Miao' <eric.y.miao@gmail.com>
Subject: Re: [PATCH v2] pwm: pxa: Use of_match_ptr()
Date: Fri, 4 Apr 2014 10:49:21 +0200 [thread overview]
Message-ID: <20140404084920.GB474@ulmo> (raw)
In-Reply-To: <000d01cf4eef$13881770$3a984650$%han@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On Thu, Apr 03, 2014 at 12:44:54PM +0900, Jingoo Han wrote:
> Use of_match_ptr(), because of_match_ptr() returns NULL pointer
> when CONFIG_OF is disabled.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> Changes since v1:
> - Add of_match_ptr() to of_match_device() in order to fix compile error
> when CONFIG_OF=n.
>
> drivers/pwm/pwm-pxa.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
I already fixed this in the PWM tree before submitting the 3.15 pull
request. What I did was rather revert the original patch because given
the use in pxa_pwm_get_id_dt() there isn't any real advantages to using
of_match_ptr() anymore.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-04-04 8:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 3:44 [PATCH v2] pwm: pxa: Use of_match_ptr() Jingoo Han
2014-04-04 8:49 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404084920.GB474@ulmo \
--to=thierry.reding@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-pwm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.