From: Dave Jones <davej@redhat.com>
To: netdev@vger.kernel.org
Cc: anjali.singhai@intel.com, jeffrey.t.kirsher@intel.com
Subject: Re: i40e: Add code to handle FD table full condition
Date: Fri, 4 Apr 2014 10:59:30 -0400 [thread overview]
Message-ID: <20140404145930.GA20434@redhat.com> (raw)
In-Reply-To: <20140403052019.CFC67661245@gitolite.kernel.org>
On Thu, Apr 03, 2014 at 05:20:19AM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=55a5e60b9f583f64a6c95cfe869dd2d65ae53a95
> Commit: 55a5e60b9f583f64a6c95cfe869dd2d65ae53a95
> Parent: 61dade7e9201162cba683cff103cebbdf06655d4
> Author: Anjali Singhai Jain <anjali.singhai@intel.com>
> AuthorDate: Wed Feb 12 06:33:25 2014 +0000
> Committer: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CommitDate: Fri Mar 14 16:30:03 2014 -0700
>
> i40e: Add code to handle FD table full condition
...
> + /* Turn off ATR first */
> + if (pf->flags | I40E_FLAG_FD_ATR_ENABLED) {
This condition is always true.
Did you mean to write something like
if (pf->flags & ~I40E_FLAG_FD_ATR_ENABLED)
perhaps ?
Same with the
} else if (pf->flags | I40E_FLAG_FD_SB_ENABLED) {
that pairs with it.
Dave
next parent reply other threads:[~2014-04-04 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140403052019.CFC67661245@gitolite.kernel.org>
2014-04-04 14:59 ` Dave Jones [this message]
2014-04-08 4:31 ` i40e: Add code to handle FD table full condition Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404145930.GA20434@redhat.com \
--to=davej@redhat.com \
--cc=anjali.singhai@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.