From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WW57l-0004n0-LN
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:29:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WW57f-0006Hz-Hw
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:29:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9005)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1WW57f-0006H3-AU
	for qemu-devel@nongnu.org; Fri, 04 Apr 2014 10:29:35 -0400
Date: Fri, 4 Apr 2014 16:29:18 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20140404162918.50469306@thinkpad>
In-Reply-To: <533EBB78.9090806@redhat.com>
References: <1396618620-27823-1-git-send-email-imammedo@redhat.com>
	<1396618620-27823-29-git-send-email-imammedo@redhat.com>
	<533EBB78.9090806@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 28/35] pc: propagate memory hotplug event
 to ACPI device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, mst@redhat.com, aik@ozlabs.ru, hutao@cn.fujitsu.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com, akong@redhat.com, quintela@redhat.com, armbru@redhat.com, aliguori@amazon.com, jan.kiszka@siemens.com, lersek@redhat.com, ehabkost@redhat.com, marcel.a@redhat.com, stefanha@redhat.com, chegu_vinod@hp.com, rth@twiddle.net, kwolf@redhat.com, s.priebe@profihost.ag, mreitz@redhat.com, vasilis.liaskovitis@profitbricks.com, afaerber@suse.de

On Fri, 04 Apr 2014 16:02:32 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 04/04/2014 15:36, Igor Mammedov ha scritto:
> > +    acpi_dev = (acpi_dev = piix4_pm_find()) ? acpi_dev : ich9_lpc_find();
> > +    if (!acpi_dev) {
> > +        error_setg(&local_err,
> > +                   "memory hotplug is not enabled: missing acpi device");
> 
> errp, not &local_err.
> 
> Paolo
>
or better for consistency with th rest of code:
+        goto out;
-        return;
> > +    }
> > +
> 
> 

-- 
Regards,
  Igor