Re: [PATCH 1/2] libata: Expose trim capability in sysfs

[Marc MERLIN <marc@merlins.org>]

On Wed, Apr 02, 2014 at 01:26:16PM -0400, Martin K. Petersen wrote:
> >>>>> "Tejun" == Tejun Heo <tj@kernel.org> writes:
> 
> >> Now that drives with support for queued trim are starting to appear,
> >> it would be helpful to expose the chosen trim mode to
> >> userland. Create a
> 
> Tejun> Can you please be a bit more elaborate with how it'd be helpful?
> Tejun> Do we have actual use cases for it?
> 
> There have been several threads on linux-btrfs and elsewhere where
> people have asked whether queued trim is supported by their drive or
> not. This information currently isn't reported anywhere. I thought it
> would be convenient to have a sysfs attribute that people could inspect
> to find out.

Hi Tejun,

I haven't had time to pull a new kernel and install the patches I need and
this one yet (sorry), but I wanted to give a +1 to that.

If queued trim is not available, people may want to disable trim if they
want fast performance for rm.
But indeed currently it's pretty hard to know if your drive supports it.

Thanks,
Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/