From: "Westerberg, Mika" <mika.westerberg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "Du, Wenkai" <wenkai.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable
Date: Fri, 4 Apr 2014 21:16:13 +0300 [thread overview]
Message-ID: <20140404181613.GB19349@intel.com> (raw)
In-Reply-To: <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70E1F-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Fri, Apr 04, 2014 at 08:05:23PM +0300, Du, Wenkai wrote:
> diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
> index 14c4b30..71a3fa9 100644
> --- a/drivers/i2c/busses/i2c-designware-core.c
> +++ b/drivers/i2c/busses/i2c-designware-core.c
> @@ -417,6 +417,9 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev)
> */
> dw_writel(dev, msgs[dev->msg_write_idx].addr | ic_tar, DW_IC_TAR);
>
> + /* disable interrupts */
> + i2c_dw_disable_int(dev);
> +
Please move this to i2c_dw_init() as I previously commented. This can only
happen once the controller comes out of reset (either boot, or resume from
system sleep).
> /* Enable the adapter */
> __i2c_dw_enable(dev, true);
>
> --
> 1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: "Westerberg, Mika" <mika.westerberg@intel.com>
To: "Du, Wenkai" <wenkai.du@intel.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable
Date: Fri, 4 Apr 2014 21:16:13 +0300 [thread overview]
Message-ID: <20140404181613.GB19349@intel.com> (raw)
In-Reply-To: <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70E1F@ORSMSX109.amr.corp.intel.com>
On Fri, Apr 04, 2014 at 08:05:23PM +0300, Du, Wenkai wrote:
> diff --git a/drivers/i2c/busses/i2c-designware-core.c b/drivers/i2c/busses/i2c-designware-core.c
> index 14c4b30..71a3fa9 100644
> --- a/drivers/i2c/busses/i2c-designware-core.c
> +++ b/drivers/i2c/busses/i2c-designware-core.c
> @@ -417,6 +417,9 @@ static void i2c_dw_xfer_init(struct dw_i2c_dev *dev)
> */
> dw_writel(dev, msgs[dev->msg_write_idx].addr | ic_tar, DW_IC_TAR);
>
> + /* disable interrupts */
> + i2c_dw_disable_int(dev);
> +
Please move this to i2c_dw_init() as I previously commented. This can only
happen once the controller comes out of reset (either boot, or resume from
system sleep).
> /* Enable the adapter */
> __i2c_dw_enable(dev, true);
>
> --
> 1.7.9.5
next prev parent reply other threads:[~2014-04-04 18:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 17:05 [PATCH] i2c-designware: Mask interrupts during i2c controller enable Du, Wenkai
[not found] ` <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70E1F-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-04 18:16 ` Westerberg, Mika [this message]
2014-04-04 18:16 ` Westerberg, Mika
[not found] ` <20140404181613.GB19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-04 18:20 ` Du, Wenkai
2014-04-04 18:20 ` Du, Wenkai
[not found] ` <7286EAF50D3F4E4AADE7FEECEBF8B5A537A70F8B-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-04 18:42 ` Westerberg, Mika
2014-04-04 18:42 ` Westerberg, Mika
[not found] ` <20140404184232.GC19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-04 21:54 ` Du, Wenkai
2014-04-04 21:54 ` Du, Wenkai
[not found] ` <7286EAF50D3F4E4AADE7FEECEBF8B5A537A71351-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-04-05 6:13 ` Westerberg, Mika
2014-04-05 6:13 ` Westerberg, Mika
[not found] ` <20140405061316.GF19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-06 17:58 ` One Thousand Gnomes
2014-04-06 17:58 ` One Thousand Gnomes
[not found] ` <20140406185818.3aaca03d-mUKnrFFms3BCCTY1wZZT65JpZx93mCW/@public.gmane.org>
2014-04-07 9:04 ` Westerberg, Mika
2014-04-07 9:04 ` Westerberg, Mika
[not found] ` <20140407090403.GG19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-07 14:42 ` One Thousand Gnomes
2014-04-07 14:42 ` One Thousand Gnomes
2014-04-07 15:11 ` Westerberg, Mika
[not found] ` <20140407151107.GL19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-07 16:48 ` Du, Wenkai
2014-04-07 16:48 ` Du, Wenkai
2014-04-08 10:30 ` Westerberg, Mika
2014-04-09 23:45 ` Du, Wenkai
2014-04-10 9:08 ` Westerberg, Mika
[not found] ` <20140410090826.GW19349-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-04-10 23:06 ` Du, Wenkai
2014-04-10 23:06 ` Du, Wenkai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404181613.GB19349@intel.com \
--to=mika.westerberg-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wenkai.du-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.