From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/4] drm/dp/i2c: Update comments about common i2c over dp assumptions Date: Fri, 4 Apr 2014 21:47:05 +0300 Message-ID: <20140404184704.GB4481@intel.com> References: <1396633926-10403-1-git-send-email-alexander.deucher@amd.com> <1396633926-10403-4-git-send-email-alexander.deucher@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 85CA46EDE1 for ; Fri, 4 Apr 2014 11:47:17 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1396633926-10403-4-git-send-email-alexander.deucher@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher Cc: Alex Deucher , Jani Nikula , treding@nvidia.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Apr 04, 2014 at 01:52:05PM -0400, Alex Deucher wrote: > If you are using the common dp over i2c functionality, it is > asumed that the aux transfer function does not modify the any > of the msg structure other than the reply field. Doing so > breaks the logic in the common code. > = > Signed-off-by: Alex Deucher > Cc: Ville Syrj=E4l=E4 > Cc: Jani Nikula > Cc: Thierry Reding Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/drm_dp_helper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_hel= per.c > index 125f84d..7a8c091 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -577,7 +577,9 @@ static u32 drm_dp_i2c_functionality(struct i2c_adapte= r *adapter) > = > /* > * Transfer a single I2C-over-AUX message and handle various error condi= tions, > - * retrying the transaction as appropriate. > + * retrying the transaction as appropriate. It is assumed that the > + * aux->transfer function does not modify anything in the msg other than= the > + * reply field. > */ > static int drm_dp_i2c_do_msg(struct drm_dp_aux *aux, struct drm_dp_aux_m= sg *msg) > { > -- = > 1.8.3.1 -- = Ville Syrj=E4l=E4 Intel OTC