From: Josh Triplett <josh@joshtriplett.org>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ana Rey <anarey@gmail.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Pablo Neira Ayuso <pablo@gnumonks.org>,
Rashika Kheria <rashika.kheria@gmail.com>,
Andreea-Cristina Bernat <bernat.ada@gmail.com>,
Andrea Merello <andrea.merello@gmail.com>,
Teodora Baluta <teobaluta@gmail.com>,
Dan LaManna <dan.lamanna@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static
Date: Sun, 6 Apr 2014 09:09:03 -0700 [thread overview]
Message-ID: <20140406160903.GA8114@leaf> (raw)
In-Reply-To: <1396799183-7412-1-git-send-email-hahnjo@hahnjo.de>
On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> This patch solves some sparse warnings about "symbol [...] was not
> declared. Should it be static?" by including the correct header files.
>
> Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Tested by compile only
>
> drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c | 1 +
> drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c | 1 +
> drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c | 1 +
> drivers/staging/rtl8187se/r8180_wx.c | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> index 101f0c0..03462c3 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> @@ -19,6 +19,7 @@
> #include <linux/string.h>
> #include <linux/errno.h>
>
> +#include "../r8180.h"
> #include "ieee80211.h"
>
> MODULE_AUTHOR("Jouni Malinen");
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> index 4fe2538..7eae3d9 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> @@ -21,6 +21,7 @@
> #include <linux/string.h>
> #include <linux/wireless.h>
>
> +#include "../r8180.h"
> #include "ieee80211.h"
>
> #include <linux/crypto.h>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> index f253672..288f86c 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> @@ -17,6 +17,7 @@
> #include <linux/skbuff.h>
> #include <linux/string.h>
>
> +#include "../r8180.h"
> #include "ieee80211.h"
>
> #include <linux/crypto.h>
> diff --git a/drivers/staging/rtl8187se/r8180_wx.c b/drivers/staging/rtl8187se/r8180_wx.c
> index b552491..57bf01f 100644
> --- a/drivers/staging/rtl8187se/r8180_wx.c
> +++ b/drivers/staging/rtl8187se/r8180_wx.c
> @@ -20,6 +20,7 @@
>
> #include "r8180.h"
> #include "r8180_hw.h"
> +#include "r8180_wx.h"
>
> #include <net/iw_handler.h>
> #include "ieee80211/dot11d.h"
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-04-06 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-06 15:46 [PATCH] staging: rtl8187se: Fix warning symbol should be static Jonas Hahnfeld
2014-04-06 16:09 ` Josh Triplett [this message]
2014-04-07 1:34 ` Stefan Lippers-Hollmann
2014-04-07 14:44 ` Jonas Hahnfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140406160903.GA8114@leaf \
--to=josh@joshtriplett.org \
--cc=anarey@gmail.com \
--cc=andrea.merello@gmail.com \
--cc=bernat.ada@gmail.com \
--cc=dan.lamanna@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hahnjo@hahnjo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pablo@gnumonks.org \
--cc=paul.gortmaker@windriver.com \
--cc=rashika.kheria@gmail.com \
--cc=teobaluta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.