From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49554)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WX5OY-0007KD-BO
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:59:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WX5OS-0005QB-7k
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:59:10 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20432)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1WX5OR-0005Q3-Vn
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:59:04 -0400
Date: Mon, 7 Apr 2014 11:59:41 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140407085941.GA14183@redhat.com>
References: <1396776125-5419-1-git-send-email-mst@redhat.com>
	<20140407105702.2562dfb1@nial.usersys.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20140407105702.2562dfb1@nial.usersys.redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.0] dsdt: tweak ACPI ID for hotplug
 resource device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Mon, Apr 07, 2014 at 10:57:02AM +0200, Igor Mammedov wrote:
> On Sun, 6 Apr 2014 12:47:37 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>=20
> > ACPI0004 seems too new:
> > Windows XP complains about an unrecognized device.
> > This is a regression since 1.7.
> > Use PNP0A06 instead - Generic Container Device.
> >=20
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >=20
> > Note: Igor has RFC patches to use PNP0C02 under PCI0,
> > but that's not ready for 2.0.
> > Igor, could you comment on whether PNP0C02 is preferable for
> > some OS-es?
> >=20
> > For PNP0A06 ACPI spec says:
> >     PNP0A06
> >     Generic Container Device. This device behaves exactly the same as=
 the
> >     PNP0A05 device.
> >     This was originally known as Extended I/O Bus. This ID should onl=
y be
> >     used for containers
> >     that do not produce resources for consumption by child devices. A=
ny
> >     system resources
> >     claimed by a PNP0A06 device=E2=80=99s _CRS object must be consume=
d by the
> >     container itself.
> >=20
> > PNP0C02 is not in ACPI spec. It does appear in MicroSoft legacy PNP I=
D
> > document:
> >     PNP0C02         General ID for reserving resources required by Pl=
ug and
> >     Play motherboard registers. (Not specific to a particular device.=
)
> >=20
> > Thoughts?
> >=20
> >  hw/i386/acpi-dsdt-cpu-hotplug.dsl | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cp=
u-hotplug.dsl
> > index dee4843..34aab5a 100644
> > --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> > +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> > @@ -93,7 +93,7 @@ Scope(\_SB) {
> >      }
> > =20
> >      Device(CPU_HOTPLUG_RESOURCE_DEVICE) {
> > -        Name(_HID, "ACPI0004")
> > +        Name(_HID, EisaId("PNP0A06"))
> > =20
> >          Name(_CRS, ResourceTemplate() {
> >              IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_ST=
ATUS_LEN)
>=20
> Reviewed-By: Igor Mammedov <imammedo@redhat.com>

Thanks!
Peter, could you pick this up for 2.0 please?

--=20
MST